Skip to content

Redesign: fix conferences admin module issues#11703

Merged
andreslucena merged 3 commits intodevelopfrom
fix/conferences-admin
Oct 4, 2023
Merged

Redesign: fix conferences admin module issues#11703
andreslucena merged 3 commits intodevelopfrom
fix/conferences-admin

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR fixes the assemblies admin module issues revealed by #11603

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added module: conferences project: redesign Barcelona City Council contract labels Oct 2, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Oct 2, 2023
@alecslupu alecslupu force-pushed the fix/conferences-admin branch from d92269a to 50d2220 Compare October 2, 2023 18:25
@alecslupu alecslupu requested a review from a team October 2, 2023 19:16
@alecslupu alecslupu marked this pull request as ready for review October 2, 2023 19:16
@andreslucena andreslucena changed the title Redesign: Fix conferences admin module issues Redesign: fix conferences admin module issues Oct 3, 2023
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a removal of a few classes and we're good to go

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu requested a review from andreslucena October 3, 2023 11:36
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more removal and this is ready

…ence_copies/_form.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu requested a review from andreslucena October 3, 2023 13:38
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@andreslucena andreslucena merged commit 46a5ff5 into develop Oct 4, 2023
@andreslucena andreslucena deleted the fix/conferences-admin branch October 4, 2023 08:07
@andreslucena andreslucena added no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug labels Oct 4, 2023
entantoencuanto added a commit that referenced this pull request Oct 6, 2023
* feature/renaming-redesign:
  Use default current participatory space scope as root on scopes_select_tag called from bulk actions
  restore the imports thing (compilation fails for initiatives)
  change testing color: dequelabs/axe-core#3513 (comment)
  Fix admin redesign module (#11648)
  Apply flash styles to Announcements (#11708)
  Refactor oneliners of redesigned_a11y.js (#11713)
  Redesign: fix votings admin module issues (#11704)
  Add meta robots noindex to search and profile (#10120)
  Refactor dropdown scroll to menu (#11710)
  Remove unused partial
  Remove REDESIGN_PENDING obsolete comand
  Redesign: fix assembly members sidebar menu (#11699)
  Redesign: fix conferences admin module issues (#11703)
  Redesign: fix assemblies admin module issues (#11702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: conferences no-backport Pull Requests that should not be backported project: redesign Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Admin conferences Issues

2 participants