Redesign: fix assemblies admin module issues#11702
Merged
andreslucena merged 4 commits intodevelopfrom Oct 4, 2023
Merged
Conversation
andreslucena
requested changes
Oct 3, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I found some details to change, can you give them a look?
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
requested changes
Oct 3, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
A bit more cleanup and this is ready to be merged
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
entantoencuanto
added a commit
that referenced
this pull request
Oct 6, 2023
* feature/renaming-redesign: Use default current participatory space scope as root on scopes_select_tag called from bulk actions restore the imports thing (compilation fails for initiatives) change testing color: dequelabs/axe-core#3513 (comment) Fix admin redesign module (#11648) Apply flash styles to Announcements (#11708) Refactor oneliners of redesigned_a11y.js (#11713) Redesign: fix votings admin module issues (#11704) Add meta robots noindex to search and profile (#10120) Refactor dropdown scroll to menu (#11710) Remove unused partial Remove REDESIGN_PENDING obsolete comand Redesign: fix assembly members sidebar menu (#11699) Redesign: fix conferences admin module issues (#11703) Redesign: fix assemblies admin module issues (#11702)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR fixes the assemblies admin module issues revealed by #11600
📌 Related Issues
Link your PR to an issue
Testing
decidim-assemblies/app/views/decidim/assemblies/admin/assemblies/index.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assemblies_settings/_form.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assemblies_settings/edit.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assemblies_types/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assemblies_types/edit.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_copies/_form.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_copies/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_copies/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_imports/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_imports/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_imports/new.html.erbdecidim-assemblies/app/views/layouts/decidim/admin/assemblies_settings.html.erbdecidim-assemblies/app/views/layouts/decidim/admin/assemblies_types.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_members/_form.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_members/edit.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_members/index.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_members/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_user_roles/_form.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_user_roles/edit.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_user_roles/new.html.erbdecidim-assemblies/app/views/decidim/assemblies/admin/assembly_user_roles/index.html.erbdecidim-assemblies/app/views/layouts/decidim/admin/assembly_members.html.erb📷 Screenshots
Please add screenshots of the changes you are proposing
