Redesign: replace cells with redesigned versions if present and update references#11123
Merged
alecslupu merged 13 commits intofeature/redesignfrom Jul 7, 2023
Merged
Conversation
c0758b3 to
ae308ea
Compare
ae308ea to
f6b6ff1
Compare
ferblape
reviewed
Jul 5, 2023
ferblape
approved these changes
Jul 5, 2023
Contributor
|
@alecslupu some of the comments in #11122 are being addressed in this PR and in #11126 (and maybe there will be others to completely remove the redesigned stuff) We'd like to merge this one ASAP, do you want to take a look before I merge it? |
Contributor
|
@ferblape please fix the pipeline. |
alecslupu
suggested changes
Jul 6, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
The PR is looking good.
I would just make sure the pipeline is green, and i would like to see your point of view on the rest of the comments.
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
f2b4b3b to
4db2209
Compare
alecslupu
approved these changes
Jul 7, 2023
entantoencuanto
added a commit
that referenced
this pull request
Jul 7, 2023
* feature/redesign: Redesign: replace cells with redesigned versions if present and update references (#11123) Remove duplicated constant Simplify logic Enable specs Fix leaflet fix failing specs Fix issues with overriding maps and loading Leaflet (#11105) Update decidim-proposals/app/views/decidim/proposals/proposals/new.html.erb Update decidim-comments/lib/decidim/comments/comments_helper.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Document how to work locally with Elections/Votings (#10870) Fix Admin dashboard disappear if you are in Trustee Zone (#11111) Fix Shakapacker upgrade does not work for existing instances (#10814) Fix for sending welcome emails for new participants (#10991) Fix seeded trustees (#10964)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR:
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you are proposing
