Fix Admin dashboard disappear if you are in Trustee Zone#11111
Merged
andreslucena merged 2 commits intodevelopfrom Jul 3, 2023
Merged
Fix Admin dashboard disappear if you are in Trustee Zone#11111andreslucena merged 2 commits intodevelopfrom
andreslucena merged 2 commits intodevelopfrom
Conversation
andreslucena
requested changes
Jul 3, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
Tried it locally and it works perfect, nice catch! I have a cosmetic change and it is ready to be merged
decidim-elections/app/controllers/decidim/elections/trustee_zone/application_controller.rb
Outdated
Show resolved
Hide resolved
Member
|
Also congratulations in opening the issue 11111 🥇 🥳
|
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This was referenced Jul 3, 2023
entantoencuanto
added a commit
that referenced
this pull request
Jul 7, 2023
* feature/redesign: Redesign: replace cells with redesigned versions if present and update references (#11123) Remove duplicated constant Simplify logic Enable specs Fix leaflet fix failing specs Fix issues with overriding maps and loading Leaflet (#11105) Update decidim-proposals/app/views/decidim/proposals/proposals/new.html.erb Update decidim-comments/lib/decidim/comments/comments_helper.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Document how to work locally with Elections/Votings (#10870) Fix Admin dashboard disappear if you are in Trustee Zone (#11111) Fix Shakapacker upgrade does not work for existing instances (#10814) Fix for sending welcome emails for new participants (#10991) Fix seeded trustees (#10964)
andreslucena
added a commit
that referenced
this pull request
Jul 18, 2023
* Fix Admin dashboard disappear if you are in Trustee Zone * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While reviewing #10870 i came across the need of switching between Trustee zone in profile and Admin Dashboard. I saw that Admin menu disappeared in that particular page, and i have remembered about #9586
.
📌 Related Issues
Link your PR to an issue
Testing