Fix Shakapacker upgrade does not work for existing instances#10814
Merged
andreslucena merged 6 commits intodecidim:developfrom Jul 3, 2023
Merged
Fix Shakapacker upgrade does not work for existing instances#10814andreslucena merged 6 commits intodecidim:developfrom
andreslucena merged 6 commits intodecidim:developfrom
Conversation
andreslucena
requested changes
Jun 29, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I have one doubt and one suggestion, can you check it out 🙏🏽?
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
approved these changes
Jul 3, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
👍🏽 works perfect if you actually follow all the steps of the RELEASE_NOTES 🤣
entantoencuanto
added a commit
that referenced
this pull request
Jul 7, 2023
* feature/redesign: Redesign: replace cells with redesigned versions if present and update references (#11123) Remove duplicated constant Simplify logic Enable specs Fix leaflet fix failing specs Fix issues with overriding maps and loading Leaflet (#11105) Update decidim-proposals/app/views/decidim/proposals/proposals/new.html.erb Update decidim-comments/lib/decidim/comments/comments_helper.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Document how to work locally with Elections/Votings (#10870) Fix Admin dashboard disappear if you are in Trustee Zone (#11111) Fix Shakapacker upgrade does not work for existing instances (#10814) Fix for sending welcome emails for new participants (#10991) Fix seeded trustees (#10964)
andreslucena
added a commit
that referenced
this pull request
Jul 18, 2023
* Fix Shakapacker upgrade does not work for existing instances * Remove uneeded task * Update the release notes * Remove webpacker related files * running linters * Update RELEASE_NOTES.md Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR attempts to fix issue reported in #10800.
It will remove
bin/webpack,bin/webpack-dev-serverand install the shakapacker binaries:bin/webpackerandbin/webpacker-dev-server.While I was working on this, i have noticed that
.ruby-versionwas not changed from3.0.2to3.1.1.📌 Related Issues
Link your PR to an issue
Testing
Generate a Decidim 0.27 application, and follow the upgrade steps.