Skip to content

Fix seeded trustees#10964

Merged
alecslupu merged 1 commit intodevelopfrom
fix/seeded-trustees
Jul 2, 2023
Merged

Fix seeded trustees#10964
alecslupu merged 1 commit intodevelopfrom
fix/seeded-trustees

Conversation

@andreslucena
Copy link
Copy Markdown
Member

@andreslucena andreslucena commented Jun 7, 2023

🎩 What? Why?

On #10901, I made a mistake where the Trustees could not actually be used for the Key Generation ceremony. That's the whole point for them :/

This PR fixes it

📌 Related Issues

Testing

(Before the patch)

  1. Having a Bulletin Board working (like the one from Document how to work locally with Elections/Votings #10870)
  2. Run the seeds
  3. Sign in as admin@example.org
  4. Go to http://localhost:3000/trustee/
  5. Generate the identification key. See that you still can generate it
  6. Apply the patch
  7. Rerun the seeds
  8. Sign in as admin@example.org
  9. Go to http://localhost:3000/trustee/
  10. Generate the identification key. See that you can not generate it again

♥️ Thank you!

@andreslucena andreslucena added module: elections type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jun 7, 2023
@andreslucena andreslucena requested a review from a team June 7, 2023 15:09
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jun 10, 2023

I tested the seeds, and i could see there are only 3 systems generated. Unfortunately, i could generate on my setup the trustee identification keys, maybe due to local setup.

@andreslucena
Copy link
Copy Markdown
Member Author

andreslucena commented Jun 12, 2023

Unfortunately, i could generate on my setup the trustee identification keys, maybe due to local setup.

I'd said this is probably related to the UX mess that we have in Elections. Just to recap all the necessary steps for this to actually work:

  1. You need to have a working Bulletin Board installation locally. I'm always trying with the one from Document how to work locally with Elections/Votings #10870, and as far as I see that seems to do the trick (with this docker-compose file: https://github.com/decidim/decidim/blob/docs/elections-development/decidim-elections/docs/docker/bulletin_board/docker-compose.yml)
  2. Use the seeds from this PR
  3. Sign in as admin
  4. In the admin dashboard, go to an Election inside of a Participatory Process
  5. Check that it's fullfilling all the requirements for setting up an Election in the "Manage steps" screen (ie the URL is http://localhost:3000/admin/participatory_processes/book-strap/components/44/manage/elections/14/steps)
  6. Once all of this is OK, then click on the "Setup election" button
  7. As one of the Trustees (for instance, admin@example.org) go to the "Trustee zone" (http://localhost:3000/trustee)
  8. Follow the steps there (downloading the key, uploading it, etc)

I'm reviewing the steps from the PR body and I think that I missed the steps 4, 5 and 6 on the process, so I think that's why you can't see it on Trustees, I missed the setup part 😄

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 2, 2023

while reviewing this is noticed that the flash is not properly displayed
image

alecslupu
alecslupu approved these changes Jul 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have managed to finally test it, and LGTM

@alecslupu alecslupu merged commit 7a30c84 into develop Jul 2, 2023
@alecslupu alecslupu deleted the fix/seeded-trustees branch July 2, 2023 09:57
entantoencuanto added a commit that referenced this pull request Jul 7, 2023
@entantoencuanto
Merge branch 'feature/redesign' into feature/redesign-rename-layouts
9c34eec 
* feature/redesign:
  Redesign: replace cells with redesigned versions if present and update references (#11123)
  Remove duplicated constant
  Simplify logic
  Enable specs
  Fix leaflet
  fix failing specs
  Fix issues with overriding maps and loading Leaflet (#11105)
  Update decidim-proposals/app/views/decidim/proposals/proposals/new.html.erb
  Update decidim-comments/lib/decidim/comments/comments_helper.rb
  Update decidim-assemblies/spec/system/filter_assemblies_spec.rb
  Update decidim-assemblies/spec/system/filter_assemblies_spec.rb
  Document how to work locally with Elections/Votings (#10870)
  Fix Admin dashboard disappear if you are in Trustee Zone (#11111)
  Fix Shakapacker upgrade does not work for existing instances (#10814)
  Fix for sending welcome emails for new participants (#10991)
  Fix seeded trustees (#10964)
andreslucena added a commit that referenced this pull request Jul 18, 2023
@andreslucena
Fix seeded trustees (#10964)
e7d24a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alecslupu alecslupu alecslupu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alecslupu alecslupu

Labels

module: elections type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreslucena @alecslupu