Fix for sending welcome emails for new participants#10991
Merged
Conversation
Contributor
|
@andreslucena I changed the label from bug to fix :) I guess you want to introduce a bug fix :D |
Member
Author
Yes, of course!! I went too fast and in automatic pilot 😅 |
alecslupu
approved these changes
Jul 2, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
LGTM.
Tested, and with this patch the welcome notification is being sent.
entantoencuanto
added a commit
that referenced
this pull request
Jul 7, 2023
* feature/redesign: Redesign: replace cells with redesigned versions if present and update references (#11123) Remove duplicated constant Simplify logic Enable specs Fix leaflet fix failing specs Fix issues with overriding maps and loading Leaflet (#11105) Update decidim-proposals/app/views/decidim/proposals/proposals/new.html.erb Update decidim-comments/lib/decidim/comments/comments_helper.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Update decidim-assemblies/spec/system/filter_assemblies_spec.rb Document how to work locally with Elections/Votings (#10870) Fix Admin dashboard disappear if you are in Trustee Zone (#11111) Fix Shakapacker upgrade does not work for existing instances (#10814) Fix for sending welcome emails for new participants (#10991) Fix seeded trustees (#10964)
andreslucena
added a commit
that referenced
this pull request
Jul 18, 2023
* Fix for sending welcome emails for new participants * Refactor spec to shared examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Reviewing old PRs, I found that the welcome email feature wasn't working with the introduction of digest emails (see #8486). @arusa explained it really well in #10470:
Then @ahukkanen explained how to approach this exception change in a comment, and as its a PR that's without much movement, it's an ongoing bug on the last release, and we already have the code, I went ahead and do it 😄
Thanks both of you for detecting and telling how to fix this! 👏🏽 👏🏽
📌 Related Issues
Testing
📷 Screenshots