Add a button to send a newsletter to the admin#10896
Merged
andreslucena merged 14 commits intodecidim:developfrom Jun 21, 2023
Merged
Add a button to send a newsletter to the admin#10896andreslucena merged 14 commits intodecidim:developfrom
andreslucena merged 14 commits intodecidim:developfrom
Conversation
Member
|
Hi @ElviaBth, sorry for missing this one! We didn't check out that this was ready to be reviewed until now, that I was checking out old PRs. I think the failing specs are related to #10916, could you please merge with develop so they are fixed 🙏🏽 ? Also @microstudi tyou |
…_test_for_newsletters
…openpoke/decidim into feature/send_email_test_for_newsletters
andreslucena
requested changes
Jun 15, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've tried it locally and it works correctly 👏🏽 👏🏽
There are a couple suggestions for improving this and it should be ready to be merged
microstudi
reviewed
Jun 16, 2023
andreslucena
requested changes
Jun 19, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
One last set of really small changes and it should be ready. Can you check them out please?
Contributor
Author
|
Hi @andreslucena, I think is ready. Can you take a look, please? Thanks. |
andreslucena
approved these changes
Jun 21, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
👍🏽 great, thanks for the PR!
entantoencuanto
added a commit
that referenced
this pull request
Jul 3, 2023
* redesign/sync-develop-2: (150 commits) Adapt tests to redesign Fix stylelint offenses Fix linter offenses Fix sanitizer Recover deleted translation Recover test fix Fix method definition and syntax Check for supported locale in Emoji picker (#11079) Fix configuration param and documentation links in CSP (#11098) Show all projects if none is selected when the voting has finished (#11090) Add Content Security Policy support (#10700) Replace `bootstrap-tagsinput` npm package with `tom-select` (#11076) Avoid password change to be requested when user registration mode is disabled (#11070) Lock sass-embedded to 1.62 (#11074) Add a button to send a newsletter to the admin (#10896) Fixing more tests Fixing more specs Fixing most of the failings specs Fixing most of the failings specs Bump doorkeeper from 5.5.4 to 5.6.6 (#11002) ...
13 tasks
ElviaBth
added a commit
to openpoke/decidim
that referenced
this pull request
Jul 12, 2023
* add test send a test mail to the logged user * test it will check email has been sent * test it will check email has been sent * test admin send emails from index * test admin receives the test newsletter * Update code after review suggestions * remove restriction to send a newsletter email * fix string error in newsletters test * add context to test title and remove yarn.lock file * add context to test description * replace if ! condition by unless --------- Co-authored-by: Ivan Vergés <ivan@pokecode.net>
andreslucena
pushed a commit
that referenced
this pull request
Jul 18, 2023
* add test send a test mail to the logged user * test it will check email has been sent * test it will check email has been sent * test admin send emails from index * test admin receives the test newsletter * Update code after review suggestions * remove restriction to send a newsletter email * fix string error in newsletters test * add context to test title and remove yarn.lock file * add context to test description * replace if ! condition by unless --------- Co-authored-by: Ivan Vergés <ivan@pokecode.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
To have the option of sending a test email to the logged user email account.
I add a button to the index and show views, by clicking it a newsletter test will be sent to the logged user.
fixes #6539
Testing
📷 Screenshots