Replace bootstrap-tagsinput npm package with tom-select#11076
Merged
Replace bootstrap-tagsinput npm package with tom-select#11076
bootstrap-tagsinput npm package with tom-select#11076Conversation
bootstrap-tagsinput npm package with tom-select
a31f262 to
207e33c
Compare
alecslupu
suggested changes
Jun 21, 2023
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
@andreslucena Thanks for taking the lead on this.
The implementation of tom-select looks nice. I have a small recommendation regarding the approach on the .scss files
Suggested by code review
alecslupu
approved these changes
Jun 21, 2023
Contributor
There was a problem hiding this comment.
LGTM.
Thanks @andreslucena ! Feel free to merge.
entantoencuanto
added a commit
that referenced
this pull request
Jul 3, 2023
* redesign/sync-develop-2: (150 commits) Adapt tests to redesign Fix stylelint offenses Fix linter offenses Fix sanitizer Recover deleted translation Recover test fix Fix method definition and syntax Check for supported locale in Emoji picker (#11079) Fix configuration param and documentation links in CSP (#11098) Show all projects if none is selected when the voting has finished (#11090) Add Content Security Policy support (#10700) Replace `bootstrap-tagsinput` npm package with `tom-select` (#11076) Avoid password change to be requested when user registration mode is disabled (#11070) Lock sass-embedded to 1.62 (#11074) Add a button to send a newsletter to the admin (#10896) Fixing more tests Fixing more specs Fixing most of the failings specs Fixing most of the failings specs Bump doorkeeper from 5.5.4 to 5.6.6 (#11002) ...
andreslucena
added a commit
that referenced
this pull request
Jul 18, 2023
* Remove bootstrap-tagsinput npm package * Add tom-select npm package * Remove 'No results found' message * Fix CSS margins * Sync input-tags.scss from decidim-core with the decidim-system CSS * Enable 'remove button' feature * Fix eslint offenses * Reference the same SCSS file instead of duplicating it Suggested by code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We're using an unmaintained JS package for the input tags feature in /system panel, in the File uploads' organization form.
Last release was 8 years ago: https://www.npmjs.com/package/bootstrap-tagsinput
This has a dependabot alert:
Sometime ago we discussed some alternatives for this feature (see #8683). One of the alternatives proposed was tom-select, that I think that we could also use for other select fields (as I mentioned in #11039 (comment))
📌 Related Issues
Testing
📷 Screenshots
Before
decidim-system-input_tags-2023-06-21_14.45.07.mp4
After
decidim-system-input_tags-tom.select-2023-06-21_15.26.09.mp4