Skip to content

Lock sass-embedded to 1.62 #11074

Merged
andreslucena merged 1 commit intodevelopfrom
chore/fix-sass-embedded
Jun 21, 2023
Merged

Lock sass-embedded to 1.62 #11074
andreslucena merged 1 commit intodevelopfrom
chore/fix-sass-embedded

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jun 21, 2023

🎩 What? Why?

This PR locks the sass-embedded package to 1.62.
Latest sass-embedded release, is causing some errors to our current Decidim setup, as follows:

ERROR in ../../decidim-accountability/app/packs/stylesheets/redesigned_accountability.scss (../../decidim-accountability/app/packs/stylesheets/redesigned_accountability.scss.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[4].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[4].use[2]!./packages/webpacker/src/loaders/decidim-sass-loader.js!../../decidim-accountability/app/packs/stylesheets/redesigned_accountability.scss)
Module build failed (from ./packages/webpacker/src/loaders/decidim-sass-loader.js):
Error: Invalid "exports" main target "dist/lib/index.js" defined in the package config /home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/sass-embedded/package.json; targets must start with "./"
    at new NodeError (node:internal/errors:371:5)
    at throwInvalidPackageTarget (node:internal/modules/esm/resolve:466:9)
    at resolvePackageTargetString (node:internal/modules/esm/resolve:494:5)
    at resolvePackageTarget (node:internal/modules/esm/resolve:531:12)
    at resolvePackageTarget (node:internal/modules/esm/resolve:577:26)
    at packageExportsResolve (node:internal/modules/esm/resolve:641:22)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/packages/webpacker/src/loaders/decidim-sass-loader.js:1:14)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at loadLoader (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/loadLoader.js:19:17)
    at iteratePitchingLoaders (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:182:2)
    at iteratePitchingLoaders (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:178:10)
    at /home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:189:18
    at handleResult (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/loadLoader.js:53:2)
    at loadLoader (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/loadLoader.js:35:10)
    at iteratePitchingLoaders (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:182:2)
    at iteratePitchingLoaders (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:178:10)
    at /home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:189:18
    at handleResult (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/loadLoader.js:53:2)
    at loadLoader (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/loadLoader.js:35:10)
    at iteratePitchingLoaders (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:182:2)
    at runLoaders (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/loader-runner/lib/LoaderRunner.js:398:2)
    at NormalModule._doBuild (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/NormalModule.js:825:3)
    at NormalModule.build (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/NormalModule.js:969:15)
    at /home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/Compilation.js:1372:12
    at NormalModule.needBuild (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/NormalModule.js:1257:32)
    at Compilation._buildModule (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/Compilation.js:1353:10)
    at /home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/util/AsyncQueue.js:303:10
    at Hook.eval [as callAsync] (eval at create (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at AsyncQueue._startProcessing (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/util/AsyncQueue.js:293:26)
    at AsyncQueue._ensureProcessing (/home/runner/work/decidim/decidim/spec/decidim_dummy_app/node_modules/webpack/lib/util/AsyncQueue.js:280:12)
    at processImmediate (node:internal/timers:464:21)
 @ ../../decidim-accountability/app/packs/stylesheets/redesigned_accountability.scss
 @ ../../decidim-accountability/app/packs/entrypoints/decidim_accountability.js 4:0-51

Testing

Make sure the pipeline is green

♥️ Thank you!

@alecslupu alecslupu added module: core dependencies Pull requests that update a dependency file or issues that talk about updating dependencies javascript Pull requests that update Javascript code labels Jun 21, 2023
@alecslupu alecslupu requested a review from a team June 21, 2023 05:32
@alecslupu alecslupu marked this pull request as ready for review June 21, 2023 06:50
andreslucena
andreslucena approved these changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit f1e1f96 into develop Jun 21, 2023
@andreslucena andreslucena deleted the chore/fix-sass-embedded branch June 21, 2023 07:03
@andreslucena andreslucena added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jun 21, 2023
@andreslucena andreslucena mentioned this pull request Jun 21, 2023
Merged
@jorgeatgu jorgeatgu mentioned this pull request Jun 21, 2023
Merged
@fblupi fblupi mentioned this pull request Jun 27, 2023
Merged
entantoencuanto added a commit that referenced this pull request Jul 3, 2023
@entantoencuanto
Merge branch 'redesign/sync-develop-2' into 'feature/redesign-staging'
7138f79 
* redesign/sync-develop-2: (150 commits)
  Adapt tests to redesign
  Fix stylelint offenses
  Fix linter offenses
  Fix sanitizer
  Recover deleted translation
  Recover test fix
  Fix method definition and syntax
  Check for supported locale in Emoji picker (#11079)
  Fix configuration param and documentation links in CSP (#11098)
  Show all projects if none is selected when the voting has finished (#11090)
  Add Content Security Policy support (#10700)
  Replace `bootstrap-tagsinput` npm package with `tom-select` (#11076)
  Avoid password change to be requested when user registration mode is disabled (#11070)
  Lock sass-embedded to 1.62 (#11074)
  Add a button to send a newsletter to the admin (#10896)
  Fixing more tests
  Fixing more specs
  Fixing most of the failings specs
  Fixing most of the failings specs
  Bump doorkeeper from 5.5.4 to 5.6.6 (#11002)
  ...
andreslucena pushed a commit that referenced this pull request Jul 18, 2023
@alecslupu @andreslucena
Lock sass-embedded to 1.62 (#11074)
0392be2
@fblupi fblupi mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file or issues that talk about updating dependencies javascript Pull requests that update Javascript code module: core type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecslupu @andreslucena