Show all projects if none is selected when the voting has finished#11090
Merged
andreslucena merged 3 commits intodecidim:developfrom Jun 28, 2023
Merged
Show all projects if none is selected when the voting has finished#11090andreslucena merged 3 commits intodecidim:developfrom
andreslucena merged 3 commits intodecidim:developfrom
Conversation
|
It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR! |
Contributor
Author
|
Hi @andreslucena, this PR is done. Can you take a look, please? |
andreslucena
requested changes
Jun 27, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've tried it locally and it works as expected. I only have a tiny change to make it more clear and we're good to go.
I've also changed the title so its easier to understand in the generated CHANGELOG
decidim-budgets/app/controllers/decidim/budgets/projects_controller.rb
Outdated
Show resolved
Hide resolved
entantoencuanto
added a commit
that referenced
this pull request
Jul 3, 2023
* redesign/sync-develop-2: (150 commits) Adapt tests to redesign Fix stylelint offenses Fix linter offenses Fix sanitizer Recover deleted translation Recover test fix Fix method definition and syntax Check for supported locale in Emoji picker (#11079) Fix configuration param and documentation links in CSP (#11098) Show all projects if none is selected when the voting has finished (#11090) Add Content Security Policy support (#10700) Replace `bootstrap-tagsinput` npm package with `tom-select` (#11076) Avoid password change to be requested when user registration mode is disabled (#11070) Lock sass-embedded to 1.62 (#11074) Add a button to send a newsletter to the admin (#10896) Fixing more tests Fixing more specs Fixing most of the failings specs Fixing most of the failings specs Bump doorkeeper from 5.5.4 to 5.6.6 (#11002) ...
This was referenced Jul 4, 2023
Merged
andreslucena
pushed a commit
that referenced
this pull request
Jul 18, 2023
…11090) * Add a condition to default_filter_status method * add test to check if does not filter selected by default * add method to improve readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As long as no project has been given a "selected/unselected" status, all projects should be displayed.
📌 Related Issues
Testing
📷 Screenshots
Voting enabled:
Voting finish (not status yet)
