Refactor NvFuser transpose API to match eager mode behavior#1746
Merged
Refactor NvFuser transpose API to match eager mode behavior#1746
Conversation
00880f8 to
a4bfc72
Compare
Collaborator
|
Is |
Collaborator
Author
|
|
naoyam
reviewed
Jun 3, 2022
naoyam
reviewed
Jun 3, 2022
a4bfc72 to
91d54b4
Compare
naoyam
approved these changes
Jun 3, 2022
Collaborator
naoyam
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the comments.
jjsjann123
reviewed
Jun 3, 2022
| } | ||
|
|
||
| // returns transpose map to achieve permutation on non-permuted tensor | ||
| // note: used for codegen transpose API |
|
|
||
| TORCH_CHECK( | ||
| dim1 >= 0 && dim1 <= ndims, "Invalid transpose dimension 1: ", dim1); | ||
|
|
Collaborator
There was a problem hiding this comment.
nitpick: wasn't the negative dim handling done in ir_utils::normalizeNew2Old already, this feels like redundant checks, but does give us nice error message.
Collaborator
Author
There was a problem hiding this comment.
Dimension canonicalization only wraps around once.
If you had a 3D tensor but specified dim0 = -4, then the check will fail.
Collaborator
There was a problem hiding this comment.
Not saying that we need to change the behavior, both pytorch & numpy only wraps once and errors out for out of range.
Dimension canonicalization and the check in transpose does exactly the same thing, so it's a redundant check.
jjsjann123
added a commit
that referenced
this pull request
Jun 22, 2022
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: pytorch#79147 Approved by: https://github.com/davidberard98
jjsjann123
added a commit
that referenced
this pull request
Jun 22, 2022
…h#79406) Landing reverted PR pytorch#79147. Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: pytorch#79406 Approved by: https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the NvFuser transpose takes an
unordered_mapthat maps from old to new positions. (Similar toreorder).This PR refactors transpose to follow the
aten::permuteandaten::transposeAPIs.