Skip to content

fixing warning for gcc7#1732

Merged
jjsjann123 merged 1 commit intodevelfrom
gcc_7_warning
May 25, 2022
Merged

fixing warning for gcc7#1732
jjsjann123 merged 1 commit intodevelfrom
gcc_7_warning

Conversation

@jjsjann123
Copy link
Copy Markdown
Collaborator

@jjsjann123 jjsjann123 commented May 25, 2022

GCC 7 warns about the absense of parenthesis in upstream CI:

/var/lib/jenkins/workspace/torch/csrc/jit/codegen/cuda/lower_double_buffer.cpp:70:27: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
       def->isA<UnaryOp>() &&
       ~~~~~~~~~~~~~~~~~~~~^~
               def->as<UnaryOp>()->getUnaryOpType() == UnaryOpType::Set ||

@jjsjann123 jjsjann123 requested a review from shmsong May 25, 2022 21:59
shmsong
shmsong approved these changes May 25, 2022
View reviewed changes
Copy link
Copy Markdown

@shmsong shmsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@jjsjann123 jjsjann123 merged commit 1fd974f into devel May 25, 2022
@jjsjann123 jjsjann123 deleted the gcc_7_warning branch May 25, 2022 22:18
@naoyam naoyam mentioned this pull request May 27, 2022
Merged
jjsjann123 added a commit that referenced this pull request Jun 22, 2022
@jjsjann123 @pytorchmergebot
[nvfuser_upstream_push] nvfuser code base bump 060822 (pytorch#79147)
49c41b8 
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: pytorch#79147
Approved by: https://github.com/davidberard98
jjsjann123 added a commit that referenced this pull request Jun 22, 2022
@jjsjann123 @pytorchmergebot
[nvfuser_upstream_push] Reland: nvfuser code base bump 060822 (pytorc…
c9c402e 
…h#79406)

Landing reverted PR pytorch#79147.

Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: pytorch#79406
Approved by: https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shmsong shmsong shmsong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjsjann123 @shmsong