Conversation
…r cleanups included.
csarofeen
commented
May 27, 2022
| py::arg("dtype") = torch::jit::fuser::cuda::DataType::Float, | ||
| py::return_value_policy::reference) | ||
| .def( | ||
| // TODO: Should the inernals of this function live more explicitly in |
Owner
Author
There was a problem hiding this comment.
I don't have a known way to test this. @kevinstephano can you check this change and make sure it works please?
Collaborator
There was a problem hiding this comment.
The examples work with the change.
naoyam
approved these changes
May 27, 2022
| // Grab all the parameters from id to set the IterDomainBuilder | ||
| IterDomainBuilder(const IterDomain* id); | ||
|
|
||
| // Resets defaults for rfactor, is padded dim, padded to size, and is mma |
Collaborator
There was a problem hiding this comment.
Isn't the parallel type also considered a scheduling parameter?
Comment on lines
+71
to
+73
| (def->as<UnaryOp>()->getUnaryOpType() == UnaryOpType::Set || | ||
| // Load store op should generally support double buffering. | ||
| def->isA<LoadStoreOp>()), |
Collaborator
There was a problem hiding this comment.
I don't think this is right as def can be LoadStoreOp.
| static_rfactor_outputs); | ||
| IterDomain* idi = | ||
| IterDomainBuilder( | ||
| IrBuilder::create<Int>(s->container(), 0), |
| static_rfactor_ids_.count(m->out())); | ||
| IterDomain* merged_id = | ||
| IterDomainBuilder( | ||
| IrBuilder::create<Int>(m->container(), 0), |
… iter_domain_builder
jjsjann123
added a commit
that referenced
this pull request
Jun 22, 2022
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: pytorch#79147 Approved by: https://github.com/davidberard98
jjsjann123
added a commit
that referenced
this pull request
Jun 22, 2022
…h#79406) Landing reverted PR pytorch#79147. Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: pytorch#79406 Approved by: https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor construction of IterDomains, two minor (unrelated) cleanups included.
IterDomainBuilder's goal isn't really to be less verbose, just more explicit about which properties we really care about setting without having to duplicate default values everywhere when constructing IterDomains. Some minor cleanup here in there included as well as no one should really be manually constructing IterDomains outside of our internals.