Skip to content

[nvfuser_upstream_push] nvfuser code base bump 060822#79147

Closed
jjsjann123 wants to merge 3 commits intopytorch:masterfrom
jjsjann123:upstream_push_0608
Closed

[nvfuser_upstream_push] nvfuser code base bump 060822#79147
jjsjann123 wants to merge 3 commits intopytorch:masterfrom
jjsjann123:upstream_push_0608

Conversation

@jjsjann123
Copy link
Collaborator

@jjsjann123 jjsjann123 commented Jun 8, 2022

Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

4c60e7dff22a494632370e5df55c011007340d06 Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d98334ffa580d73ccb28fdb8c577ad296fe Fix issue #1751 (#1753)
8a69aa320bd7629e1709fe5ceb7104d2c88ec84c Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7709048170d768217fcd7083fc8387f932 Remove BroadcastWithoutStride. (#1738)
02bab16035e70734450c02124f5cdaa95cf5749d Fix flipping of a boolean flag (#1745)
465d66890c8242e811224359cbdb1c2915490741 cleanup (#1744)
26d354e68720bc7dd2d3b1338ac01b707a230b6a fixing noncontig broadcast (#1742)
856b6b2f9073662dd98ca22ba6c3540e20eb1cdd Add IterDomainBuilder (#1736)
1fd974f912cd4c1e21cbd16e2abb23598d66a02f fixing warning for gcc7 (#1732)
de2740a43a869f8272c2648e091d7b8235097db9 disabling complex in python tests for #1730 (#1733)
fbbbe0a2e7c7a63e0e2719b8bfccb759b714221a fixing MSVC build (#1728)
b5feee5e2b28be688dbddc766f3c0220389c8175 Fix the fused reduction runtime kernel (#1729)
5247682dff5980bb66edf8d3aac25dea2ef2ced5 Re-entrant GroupedGridReduction (#1727)

RUN_TORCHBENCH: nvfuser

…sarofeen/pytorch/

Squashed commits to WAR github API

Commits that's actually in this PR from the devel branch:

4c60e7d Add examples infrastructure for using nvFuser in a standalone program (pytorch#1725)
02a05d9 Fix issue pytorch#1751 (pytorch#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (pytorch#1746)
ffdf6b7 Remove BroadcastWithoutStride. (pytorch#1738)
02bab16 Fix flipping of a boolean flag (pytorch#1745)
465d668 cleanup (pytorch#1744)
26d354e fixing noncontig broadcast (pytorch#1742)
856b6b2 Add IterDomainBuilder (pytorch#1736)
1fd974f fixing warning for gcc7 (pytorch#1732)
de2740a disabling complex in python tests for pytorch#1730 (pytorch#1733)
fbbbe0a fixing MSVC build (pytorch#1728)
b5feee5 Fix the fused reduction runtime kernel (pytorch#1729)
5247682 Re-entrant GroupedGridReduction (pytorch#1727)
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 8, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 69699f4 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 8, 2022
@jjsjann123
Copy link
Collaborator Author

cc'ing @csarofeen for a stamp

@jjsjann123 jjsjann123 added ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request labels Jun 8, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 8, 2022

We have recently simplified the CIFlow labels and ciflow/slow is no longer in use.
You can use any of the following

  • ciflow/trunk (.github/workflows/trunk.yml): all jobs we run per-commit on master
  • ciflow/periodic (.github/workflows/periodic.yml): all jobs we run periodically on master
  • ciflow/android (.github/workflows/run_android_tests.yml): android build and test
  • ciflow/nightly (.github/workflows/nightly.yml): all jobs we run nightly
  • ciflow/binaries: all binary build and upload jobs
  • ciflow/binaries_conda: binary build and upload job for conda
  • ciflow/binaries_libtorch: binary build and upload job for libtorch
  • ciflow/binaries_wheel: binary build and upload job for wheel

@jjsjann123
Copy link
Collaborator Author

CI looks happy now~ cc'ing @davidberard98 so we can import it to go through internal CI.

@facebook-github-bot
Copy link
Contributor

@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll plan on landing internally tomorrow morning.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @jjsjann123.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 10, 2022
Summary:
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

Pull Request resolved: #79147

Reviewed By: zou3519

Differential Revision: D37038192

Pulled By: davidberard98

fbshipit-source-id: 330f46ee21eef5c2de7e178290f2962aa030393e
@janeyx99
Copy link
Contributor

@pytorchbot revert -m "Broke 11.3 builds on trunk https://hud.pytorch.org/pytorch/pytorch/commit/49c41b87a28848655d7fe8168e9a717d53508609" -c landrace

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

jjsjann123 added a commit to jjsjann123/pytorch that referenced this pull request Jun 13, 2022
facebook-github-bot pushed a commit that referenced this pull request Jun 13, 2022
Summary:
This reverts commit 49c41b8.

Reverted #79147 on behalf of https://github.com/janeyx99 due to Broke 11.3 builds on trunk https://hud.pytorch.org/pytorch/pytorch/commit/49c41b87a28848655d7fe8168e9a717d53508609

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d28e9e145b917bf85db479d2e811f8177a8564ea

Reviewed By: osalpekar

Differential Revision: D37089131

Pulled By: osalpekar

fbshipit-source-id: 104d151fda687e3bfc6e2e132ef2ec7d4ad6e526
pytorchmergebot pushed a commit that referenced this pull request Jun 16, 2022
Landing reverted PR #79147.

Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: #79406
Approved by: https://github.com/davidberard98
facebook-github-bot pushed a commit that referenced this pull request Jun 16, 2022
Summary:
Landing reverted PR #79147.

Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d9 Fix issue #1751 (#1753)
8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7 Remove BroadcastWithoutStride. (#1738)
02bab16 Fix flipping of a boolean flag (#1745)
465d668 cleanup (#1744)
26d354e fixing noncontig broadcast (#1742)
856b6b2 Add IterDomainBuilder (#1736)
1fd974f fixing warning for gcc7 (#1732)
de2740a disabling complex in python tests for #1730 (#1733)
fbbbe0a fixing MSVC build (#1728)
b5feee5 Fix the fused reduction runtime kernel (#1729)
5247682 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser

Pull Request resolved: #79406

Reviewed By: anjali411

Differential Revision: D37109147

Pulled By: davidberard98

fbshipit-source-id: 14209be028a3338be112cc83ffe77e631f802891
jjsjann123 added a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
4c60e7dff22a494632370e5df55c011007340d06 Add examples infrastructure for using nvFuser in a standalone program (#1725)
02a05d98334ffa580d73ccb28fdb8c577ad296fe Fix issue #1751 (#1753)
8a69aa320bd7629e1709fe5ceb7104d2c88ec84c Refactor NvFuser transpose API to match eager mode behavior (#1746)
ffdf6b7709048170d768217fcd7083fc8387f932 Remove BroadcastWithoutStride. (#1738)
02bab16035e70734450c02124f5cdaa95cf5749d Fix flipping of a boolean flag (#1745)
465d66890c8242e811224359cbdb1c2915490741 cleanup (#1744)
26d354e68720bc7dd2d3b1338ac01b707a230b6a fixing noncontig broadcast (#1742)
856b6b2f9073662dd98ca22ba6c3540e20eb1cdd Add IterDomainBuilder (#1736)
1fd974f912cd4c1e21cbd16e2abb23598d66a02f fixing warning for gcc7 (#1732)
de2740a43a869f8272c2648e091d7b8235097db9 disabling complex in python tests for #1730 (#1733)
fbbbe0a2e7c7a63e0e2719b8bfccb759b714221a fixing MSVC build (#1728)
b5feee5e2b28be688dbddc766f3c0220389c8175 Fix the fused reduction runtime kernel (#1729)
5247682dff5980bb66edf8d3aac25dea2ef2ced5 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: pytorch/pytorch#79147
Approved by: https://github.com/davidberard98
jjsjann123 added a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/

Bug fixes and minor refactor

Squashed commits to WAR github API
Commits that's actually in this PR from the devel branch:

```
69f4281 Add examples infrastructure for using nvFuser in a standalone program (#1725)
50c2598 Fix issue #1751 (#1753)
1b621de Refactor NvFuser transpose API to match eager mode behavior (#1746)
fdd555a Remove BroadcastWithoutStride. (#1738)
4d5f584 Fix flipping of a boolean flag (#1745)
6e6adfe cleanup (#1744)
68d153f fixing noncontig broadcast (#1742)
7336f20 Add IterDomainBuilder (#1736)
5b3e862 fixing warning for gcc7 (#1732)
de2740a43a869f8272c2648e091d7b8235097db9 disabling complex in python tests for #1730 (#1733)
8837c5d fixing MSVC build (#1728)
6b0f2f2 Fix the fused reduction runtime kernel (#1729)
c174176 Re-entrant GroupedGridReduction (#1727)
```

RUN_TORCHBENCH: nvfuser
Pull Request resolved: pytorch/pytorch#79147
Approved by: https://github.com/davidberard98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants