Conversation
colesbury
reviewed
Jun 5, 2017
Member
colesbury
left a comment
There was a problem hiding this comment.
Can you add a test for "Fix grad type of compare functions"?
Collaborator
|
rebased, fixed lint and pushed tests to check for matching grad_input's type for all autograd functions |
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Jun 7, 2022
* Re-entrant GroupedGridReduction
jjsjann123
added a commit
to jjsjann123/pytorch
that referenced
this pull request
Jun 8, 2022
…sarofeen/pytorch/ Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (pytorch#1725) 02a05d9 Fix issue pytorch#1751 (pytorch#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (pytorch#1746) ffdf6b7 Remove BroadcastWithoutStride. (pytorch#1738) 02bab16 Fix flipping of a boolean flag (pytorch#1745) 465d668 cleanup (pytorch#1744) 26d354e fixing noncontig broadcast (pytorch#1742) 856b6b2 Add IterDomainBuilder (pytorch#1736) 1fd974f fixing warning for gcc7 (pytorch#1732) de2740a disabling complex in python tests for pytorch#1730 (pytorch#1733) fbbbe0a fixing MSVC build (pytorch#1728) b5feee5 Fix the fused reduction runtime kernel (pytorch#1729) 5247682 Re-entrant GroupedGridReduction (pytorch#1727)
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 10, 2022
Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: #79147 Approved by: https://github.com/davidberard98
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2022
Summary: Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` Pull Request resolved: #79147 Reviewed By: zou3519 Differential Revision: D37038192 Pulled By: davidberard98 fbshipit-source-id: 330f46ee21eef5c2de7e178290f2962aa030393e
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 16, 2022
Landing reverted PR #79147. Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: #79406 Approved by: https://github.com/davidberard98
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
Summary: Landing reverted PR #79147. Syncing nvfuser devel branch to upstream master. https://github.com/csarofeen/pytorch/ Bug fixes and minor refactor Squashed commits to WAR github API Commits that's actually in this PR from the devel branch: ``` 4c60e7d Add examples infrastructure for using nvFuser in a standalone program (#1725) 02a05d9 Fix issue #1751 (#1753) 8a69aa3 Refactor NvFuser transpose API to match eager mode behavior (#1746) ffdf6b7 Remove BroadcastWithoutStride. (#1738) 02bab16 Fix flipping of a boolean flag (#1745) 465d668 cleanup (#1744) 26d354e fixing noncontig broadcast (#1742) 856b6b2 Add IterDomainBuilder (#1736) 1fd974f fixing warning for gcc7 (#1732) de2740a disabling complex in python tests for #1730 (#1733) fbbbe0a fixing MSVC build (#1728) b5feee5 Fix the fused reduction runtime kernel (#1729) 5247682 Re-entrant GroupedGridReduction (#1727) ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: #79406 Reviewed By: anjali411 Differential Revision: D37109147 Pulled By: davidberard98 fbshipit-source-id: 14209be028a3338be112cc83ffe77e631f802891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nonevalues returned from grad hooks (Backward hook for conv layers without bias #1269)masked_copy_tomasked_scatter_. The old name is still available but is deprecated (feature request: a sensible masked_copy #1662)