In cockroachdb#45451 we made the expected number of ranges reflect the current
zone config. The problem with this change is that it used a factor of
2x the minimum range size to estimate the upper bound on number of ranges.

There was no principled reason to make this assumption. We should instead
just assert that the ranges are larger than the minimum range size on average.

Release note: None

45253: storage: fix bug in calcRangeCounter r=andreimatei a=tbg

Found by @andreimatei in #39936 (review)

Release note (bug fix): a bug in the range metrics collection could fail
to correctly identify a range that had lost quorum, causing it to not be
reported via the "unavailable ranges" metric. This is now fixed.

45534: coldata: change Batch interface to operate with int length r=yuzefovich a=yuzefovich

This commit changes Batch interface to operate with `int` length
because it unifies the way we store batches - now we will have a single
implementation `MemBatch` (with an exception for `coldata.ZeroBatch`). This
allows us to remove `bufferedBatch`.

Release note: None

45554: kv: add a comment r=andreimatei a=andreimatei

Explain the surprising fact that we're telling then inflight-writes
btree to not reuse its nodes.

Release note: None

45580: storage: improve "range unavailable" log message r=nvanbenschoten a=tbg

I've had to look at this message on users clusters recently and I found
that it could be more actionable:

- adjusted the wording to steer enterprise users towards enterprise
  support
- print the range descriptor
- print which replicas we think are live
- log this message as an error instead of a warning (this message
  is always a serious problem that demands immediate attention).

Release note (general change): Improved a debug message that is printed
when a range is unavailable (i.e. unable to accept writes).

45585: roachtest: fix copy/bank roachtest to deal with smaller ranges r=ajwerner a=ajwerner

In #45451 we made the expected number of ranges reflect the current
zone config. The problem with this change is that it used a factor of
2x the minimum range size to estimate the upper bound on number of ranges.

There was no principled reason to make this assumption. We should instead
just assert that the ranges are larger than the minimum range size on average.

Release note: None

Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>

In 19.2 we changed the name of the column from
SHOW ZONE CONFIGURATION from `config_sql` to `raw_config_sql`.
I relied on this column name in cockroachdb#45451.

This change updates the test to fall back to the old defaults if the column
does not exist.

Fixes cockroachdb#45489.

Release note: None

45712: sql: prevent arbitrary writes to system.comments r=RichardJCai a=knz

Fixes #45707.

Previously, the GRANT, UPDATE, DELETE and INSERT privileges
were granted to `public`, i.e. everyone, on `system.comments`.

This was unintended - only users with permissions on an object
should be able to modify that object's comments.

This patch fixes it.

Release note (security update): Any user could previously modify any
database/table/view/index comment via direct SQL updates to
`system.comments`. This was unintended and a form of privilege
escalation, and is now prevented. The privileges required for the
COMMENT statement and `pg_description`, `col_description()`,
`obj_description()` and `shobj_description()` are operating as
in PostgreSQL and unaffected by this change: all users can *view* any
comments on any object (bypassing other privileges), but modifying
comments require write privilege on the target object.

45729: roachtest: fix copy/bank roachtest on 19.1 r=nvanbenschoten a=ajwerner

In 19.2 we changed the name of the column from
SHOW ZONE CONFIGURATION from `config_sql` to `raw_config_sql`.
I relied on this column name in #45451.

This change updates the test to fall back to the old defaults if the column
does not exist.

Fixes #45489.

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>