Conversation
Explain the surprising fact that we're telling then inflight-writes btree to not reuse its nodes. Release note: None
|
Right? |
|
This change is |
nvb
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
andreimatei
left a comment
There was a problem hiding this comment.
TFTR
well, everything about that reuse param is unclear because it's ambiguous whether it's the caller that's free to reuse something, or the callee. Once you figure out that it's the callee, you (I) would expect that when the caller is categorically done with the btree, it'd give the callee the freedom to do whatever it wants. Except here (surprisingly) the freedom comes at a price.
bors r+
Reviewable status:
Build failed |
|
roachtest infra flake
bors r+
…On Mon, Mar 2, 2020 at 11:51 AM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=1778799&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45554?email_source=notifications&email_token=AAC4C4NALHFBATYEDLO6VT3RFPPZTA5CNFSM4K67GRUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQBZEA#issuecomment-593501328>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4IA6Y66DTANVUPW6HDRFPPZTANCNFSM4K67GRUA>
.
|
Build succeeded |
Explain the surprising fact that we're telling then inflight-writes
btree to not reuse its nodes.
Release note: None