roachtest: fix copy/bank roachtest to deal with smaller ranges#45585
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 2, 2020
Merged
Conversation
Member
|
This change is |
petermattis
approved these changes
Mar 2, 2020
Collaborator
petermattis
left a comment
There was a problem hiding this comment.
LGTM
I'm taking this for a spin. I'll let you know the results in about 30 min.
Collaborator
10+10 passes (I ran each
|
Contributor
Author
|
TFTR! bors r=petermattis |
In cockroachdb#45451 we made the expected number of ranges reflect the current zone config. The problem with this change is that it used a factor of 2x the minimum range size to estimate the upper bound on number of ranges. There was no principled reason to make this assumption. We should instead just assert that the ranges are larger than the minimum range size on average. Release note: None
f5c3c96 to
7b0aa18
Compare
Contributor
Canceled |
Contributor
Author
|
license bot bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #45451 we made the expected number of ranges reflect the current
zone config. The problem with this change is that it used a factor of
2x the minimum range size to estimate the upper bound on number of ranges.
There was no principled reason to make this assumption. We should instead
just assert that the ranges are larger than the minimum range size on average.
Release note: None