storage: improve "range unavailable" log message#45580
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 2, 2020
Merged
storage: improve "range unavailable" log message#45580craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
I've had to look at this message on users clusters recently and I found that it could be more actionable: - adjusted the wording to steer enterprise users towards enterprise support - print the range descriptor - print which replicas we think are live - log this message as an error instead of a warning (this message is always a serious problem that demands immediate attention). Release note (general change): Improved a debug message that is printed when a range is unavailable (i.e. unable to accept writes).
Member
|
This change is |
nvb
approved these changes
Mar 2, 2020
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
Member
Author
|
bors r=nvanbenschoten |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had to look at this message on users clusters recently and I found
that it could be more actionable:
support
is always a serious problem that demands immediate attention).
Release note (general change): Improved a debug message that is printed
when a range is unavailable (i.e. unable to accept writes).