Skip to content

roachtest: fix copy/bank roachtest on 19.1#45729

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/fix-copy_bank-before-19.1
Mar 5, 2020
Merged

roachtest: fix copy/bank roachtest on 19.1#45729
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/fix-copy_bank-before-19.1

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner commented Mar 4, 2020

In 19.2 we changed the name of the column from
SHOW ZONE CONFIGURATION from config_sql to raw_config_sql.
I relied on this column name in #45451.

This change updates the test to fall back to the old defaults if the column
does not exist.

Fixes #45489.

Release note: None

@ajwerner ajwerner requested a review from nvb March 4, 2020 22:03
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

In 19.2 we changed the name of the column from
SHOW ZONE CONFIGURATION from `config_sql` to `raw_config_sql`.
I relied on this column name in cockroachdb#45451.

This change updates the test to fall back to the old defaults if the column
does not exist.

Fixes cockroachdb#45489.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/fix-copy_bank-before-19.1 branch from 91d0fba to 35b2e99 Compare March 5, 2020 13:07
@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Mar 5, 2020

bors r=nvanbenschoten

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 5, 2020

Build succeeded

@craig craig bot merged commit 4610ad2 into cockroachdb:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: copy/bank/rows=10000000,nodes=9,txn=true failed

3 participants