Merged
Conversation
Member
|
This change is |
Contributor
Author
|
This came up in the course of some other development. I was running into a typings problem, and upgrading will fix it. |
vilterp
reviewed
May 22, 2018
Contributor
vilterp
left a comment
There was a problem hiding this comment.
Don't see an upgrade in package.json.
| ui-lint: $(YARN_INSTALLED_TARGET) $(UI_PROTOS) | ||
| $(NODE_RUN) -C $(UI_ROOT) $(STYLINT) -c .stylintrc styl | ||
| $(NODE_RUN) -C $(UI_ROOT) $(TSLINT) -c tslint.json -p tsconfig.json --type-check | ||
| $(NODE_RUN) -C $(UI_ROOT) $(TSLINT) -c tslint.json -p tsconfig.json |
Contributor
There was a problem hiding this comment.
is the --type-check flag not needed anymore?
027223e to
e490941
Compare
Contributor
Author
Indeed. Done.
Indeed not. If you provide a |
Unfortunately a few rules triggered that weren't before, so this also includes a handful of fixes for those. Release note: None
e490941 to
ea53221
Compare
Contributor
Author
|
bors r+ |
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
May 23, 2018
25863: ui: use build version for docs links r=couchand a=couchand The first commit is reviewed separately here: #25823 #### ui: extract dataFromServer global from login file Since the dataFromServer will hold more than just login state, move it out to a new file. Release note: None #### ui: use build version for docs links Previously, the current version was hard-coded into the docs links, requiring manual effort to keep in sync with the released version of the binary. This change interpolates the `build.VersionPrefix()` instead, so that it's always correct. Fixes: #19024 Release note: None Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
couchand
added a commit
to couchand/cockroach
that referenced
this pull request
May 23, 2018
In that PR, I mechanically replaced identifiers when there were new warnings about shadowing, but in two places I accidentally changed semantics due to the shorthand form of object literals. 🤦♂️ Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 23, 2018
25868: sql: Log event for TRUNCATE TABLE r=a-robinson a=a-robinson Fixes #25867 Release note (sql change): TRUNCATE TABLE commands are now logged in the event log. 25871: ui: unbreak `make watch` r=vilterp a=vilterp By telling Webpack to proxy the path `/` through to the Cockroach process. Webpack used to serve `/` itself from a static file, but as of #25195 we generate `/` dynamically in Go, so we can use it to pass login state to the UI. Fixes #25858 Release note: None 25875: ui: fix action names broken by #25823 r=couchand a=couchand In that PR, I mechanically replaced identifiers when there were new warnings about shadowing, but in two places I accidentally changed semantics due to the shorthand form of object literals. 🤦♂️ Release note: None Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Pete Vilter <vilterp@cockroachlabs.com> Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
couchand
added a commit
to couchand/cockroach
that referenced
this pull request
May 30, 2018
In the course of the upgrade for cockroachdb#25823, I accidentally disabled all typechecking on our project. This restores it, by explicitly invoking the TypeScript compiler as part of the ui-lint task. Also included are the fixes for the type problems that snuck in while typechecking was off. Fixes: cockroachdb#26255 Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 30, 2018
26258: ui: start running typescript compiler r=vilterp a=couchand In the course of the upgrade for #25823, I accidentally disabled all typechecking on our project. This restores it, by explicitly invoking the TypeScript compiler as part of the ui-lint task. Also included are the fixes for the type problems that snuck in while typechecking was off. Fixes: #26255 Release note: None Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately a few rules triggered that weren't before, so this also
includes a handful of fixes for those.
Release note: None