This change is 

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

pkg/sql/event_log.go, line 43 at r1 (raw file):

	// EventLogDropTable is recorded when a table is dropped.
	EventLogDropTable EventLogType = "drop_table"
	// EventLogTruncateTable is recorded when a table is dropped.

truncated not dropped

pkg/ui/src/util/eventTypes.ts, line 9 at r1 (raw file):

type Event = protos.cockroach.server.serverpb.EventsResponse.Event;

// Recorded when a database is created.

might be nice to alphabetize this

pkg/ui/src/util/eventTypes.ts, line 63 at r1 (raw file):

export const databaseEvents = [CREATE_DATABASE, DROP_DATABASE];
export const tableEvents = [
  CREATE_TABLE, DROP_TABLE, TRUNCATE_TABLE, ALTER_TABLE, CREATE_INDEX,

And to alphabetize this as well

Comments from Reviewable

TFTRs!

Review status: all files reviewed at latest revision, 3 unresolved discussions.

pkg/sql/event_log.go, line 43 at r1 (raw file):

Done.

pkg/ui/src/util/eventTypes.ts, line 9 at r1 (raw file):

Right now it's grouped logically by the object being acted on, which seems kind of nice to me. Mind if I leave it as is?

pkg/ui/src/util/eventTypes.ts, line 63 at r1 (raw file):

Same as above.

Comments from Reviewable

I'm ok with the logical grouping.

One last suggestion, but feel free to leave as is.

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

pkg/ui/src/util/eventTypes.ts, line 9 at r1 (raw file):

I like the logical, but perhaps call that out and alphabetize within those groupings? The logical grouping wasn't clear to me while reviewing.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

pkg/ui/src/util/eventTypes.ts, line 9 at r1 (raw file):

I'm not gonna burn another CI cycle on this, but doing it next time would be good.

Comments from Reviewable

bors r+

Build failed (retrying...)

• GitHub CI (Cockroach)

Build failed (retrying...)

• GitHub CI (Cockroach)

Build succeeded

• GitHub CI (Cockroach)