ui: use build version for docs links#25863
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom May 23, 2018
Merged
Conversation
Unfortunately a few rules triggered that weren't before, so this also includes a handful of fixes for those. Release note: None
Since the dataFromServer will hold more than just login state, move it out to a new file. Release note: None
Previously, the current version was hard-coded into the docs links, requiring manual effort to keep in sync with the released version of the binary. This change interpolates the `build.VersionPrefix()` instead, so that it's always correct. Fixes: cockroachdb#19024 Release note: None
Member
|
This change is |
vilterp
approved these changes
May 23, 2018
Contributor
vilterp
left a comment
There was a problem hiding this comment.
Nice! Good call to move DataFromServer into its own file and give it its own type.
Any reason the update TSLint commit is in here?
Contributor
Author
|
The tslint update is here because otherwise this doesn't build... I'm not sure the details, when I was flailing around trying to figure it out I saw a suggestion somewhere on the internet to upgrade tslint, so... 🤷♂️ |
Contributor
Author
|
bors r+ |
Contributor
Build failed |
Contributor
Author
|
seems to have been a flake, filed #25870 bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 23, 2018
25863: ui: use build version for docs links r=couchand a=couchand The first commit is reviewed separately here: #25823 #### ui: extract dataFromServer global from login file Since the dataFromServer will hold more than just login state, move it out to a new file. Release note: None #### ui: use build version for docs links Previously, the current version was hard-coded into the docs links, requiring manual effort to keep in sync with the released version of the binary. This change interpolates the `build.VersionPrefix()` instead, so that it's always correct. Fixes: #19024 Release note: None Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is reviewed separately here: #25823
ui: extract dataFromServer global from login file
Since the dataFromServer will hold more than just login state, move it out to a
new file.
Release note: None
ui: use build version for docs links
Previously, the current version was hard-coded into the docs links,
requiring manual effort to keep in sync with the released version
of the binary. This change interpolates the
build.VersionPrefix()instead, so that it's always correct.
Fixes: #19024
Release note: None