ui: start running typescript compiler#26258
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 30, 2018
Merged
Conversation
In the course of the upgrade for cockroachdb#25823, I accidentally disabled all typechecking on our project. This restores it, by explicitly invoking the TypeScript compiler as part of the ui-lint task. Also included are the fixes for the type problems that snuck in while typechecking was off. Fixes: cockroachdb#26255 Release note: None
Member
|
This change is |
craig bot
pushed a commit
that referenced
this pull request
May 30, 2018
26258: ui: start running typescript compiler r=vilterp a=couchand In the course of the upgrade for #25823, I accidentally disabled all typechecking on our project. This restores it, by explicitly invoking the TypeScript compiler as part of the ui-lint task. Also included are the fixes for the type problems that snuck in while typechecking was off. Fixes: #26255 Release note: None Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
vilterp
reviewed
May 30, 2018
| sortSetting: grantsSortSetting.selector(state), | ||
| dbResponse: databaseDetails(state)[ownProps.name] && databaseDetails(state)[ownProps.name].data, | ||
| grants: selectrants(state, ownProps.name), | ||
| grants: selectGrants(state, ownProps.name), |
Contributor
There was a problem hiding this comment.
yay for unbreaking the grants page 🤦♂️
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the course of the upgrade for #25823, I accidentally disabled all
typechecking on our project. This restores it, by explicitly invoking
the TypeScript compiler as part of the ui-lint task.
Also included are the fixes for the type problems that snuck in while
typechecking was off.
Fixes: #26255
Release note: None