Skip to content

v1.18 Backports 2025-12-18#43425

Merged
julianwiedmann merged 5 commits intov1.18from
pr/v1.18-backport-2025-12-18-10-24
Dec 19, 2025
Merged

v1.18 Backports 2025-12-18#43425
julianwiedmann merged 5 commits intov1.18from
pr/v1.18-backport-2025-12-18-10-24

Conversation

@Artyop
Copy link
Copy Markdown
Contributor

@Artyop Artyop commented Dec 18, 2025

Once this PR is merged, a GitHub action will update the labels of these PRs:

 40272 42952 43095 42414 43287 43372

Dropped #43095 : multiple issue, set.go in pkg/labels do not exist in v1.18, same for types.Match
Dropped #42414 : was already backported apparently

syedazeez337 and others added 2 commits December 18, 2025 10:25
[ upstream commit 3f9bf57 ]

Signed-off-by: Syed Azeez <syedazeez337@gmail.com>
Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
[ upstream commit f4bdd95 ]

If reviews were requested by renovate or the auto-committer it means it
happened on a auto-approve PR and therefore we don't need to request
reviews from anyone.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@Artyop Artyop added kind/backports This PR provides functionality previously merged into master. backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. labels Dec 18, 2025
Copy link
Copy Markdown
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for my commits, but you'll need to slightly adapt the unit test given that one dependency doesn't exist in 1.18.

@Artyop Artyop force-pushed the pr/v1.18-backport-2025-12-18-10-24 branch 2 times, most recently from f73a98a to a018402 Compare December 18, 2025 10:27
@Artyop Artyop removed the request for review from aditighag December 18, 2025 10:56
@Artyop
Copy link
Copy Markdown
Contributor Author

Artyop commented Dec 18, 2025

/test

@Artyop Artyop marked this pull request as ready for review December 18, 2025 11:02
@Artyop Artyop requested review from a team as code owners December 18, 2025 11:02
@Artyop Artyop requested a review from brlbil December 18, 2025 11:02
[ upstream commit 6046179 ]

In preparation for addressing a bug affecting this logic, and validating
the fix, let's scaffold a basic test to cover the [RunGC] function.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
[ upstream commit c331d94 ]

Currently, the [RunGC] logic does not delete duplicated identities
(i.e., pointing to the same labels), as long as at least one of them
is actually used. Although duplicated identities should never occur
in kvstore mode thanks to locking, this has been observed happening in
the wild, and it is better to be robust in this case as well. Hence,
let's fine tune the GC logic to consider a given identity as used only
if it has any associated secondary key that also matches the actual ID.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
[ upstream commit 6a4142e ]

It appears that the ciliumidentities.txtar test is affected by two
issues. First, the update performed at line 19 is ineffective, because
none of the security labels contain the 'foo' token. Second, the
namespace labels of the second identity are inconsistent. Let's get
them fixed, and update the namespace labels to be different between
the two identities.

Fixes: 1d8c53f ("test/cmapisrv: add initial battery of script tests")
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@Artyop Artyop force-pushed the pr/v1.18-backport-2025-12-18-10-24 branch from a018402 to f1efca3 Compare December 19, 2025 13:55
@Artyop
Copy link
Copy Markdown
Contributor Author

Artyop commented Dec 19, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 19, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Dec 19, 2025
Merged via the queue into v1.18 with commit d3ea523 Dec 19, 2025
339 of 346 checks passed
@julianwiedmann julianwiedmann deleted the pr/v1.18-backport-2025-12-18-10-24 branch December 19, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants