Merged
Conversation
[ upstream commit 3f9bf57 ] Signed-off-by: Syed Azeez <syedazeez337@gmail.com> Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
[ upstream commit f4bdd95 ] If reviews were requested by renovate or the auto-committer it means it happened on a auto-approve PR and therefore we don't need to request reviews from anyone. Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
giorio94
approved these changes
Dec 18, 2025
Member
giorio94
left a comment
There was a problem hiding this comment.
Looks good for my commits, but you'll need to slightly adapt the unit test given that one dependency doesn't exist in 1.18.
f73a98a to
a018402
Compare
Contributor
Author
|
/test |
aanm
approved these changes
Dec 18, 2025
viktor-kurchenko
approved these changes
Dec 19, 2025
[ upstream commit 6046179 ] In preparation for addressing a bug affecting this logic, and validating the fix, let's scaffold a basic test to cover the [RunGC] function. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
[ upstream commit c331d94 ] Currently, the [RunGC] logic does not delete duplicated identities (i.e., pointing to the same labels), as long as at least one of them is actually used. Although duplicated identities should never occur in kvstore mode thanks to locking, this has been observed happening in the wild, and it is better to be robust in this case as well. Hence, let's fine tune the GC logic to consider a given identity as used only if it has any associated secondary key that also matches the actual ID. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
[ upstream commit 6a4142e ] It appears that the ciliumidentities.txtar test is affected by two issues. First, the update performed at line 19 is ineffective, because none of the security labels contain the 'foo' token. Second, the namespace labels of the second identity are inconsistent. Let's get them fixed, and update the namespace labels to be different between the two identities. Fixes: 1d8c53f ("test/cmapisrv: add initial battery of script tests") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
a018402 to
f1efca3
Compare
Contributor
Author
|
/test |
This was referenced Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs:
Dropped #43095 : multiple issue, set.go in pkg/labels do not exist in v1.18, same for types.Match
Dropped #42414 : was already backported apparently