pkg/redirectpolicy: Check for LRP backend pod readiness#43095
Merged
aditighag merged 1 commit intocilium:mainfrom Dec 5, 2025
Merged
pkg/redirectpolicy: Check for LRP backend pod readiness#43095aditighag merged 1 commit intocilium:mainfrom
aditighag merged 1 commit intocilium:mainfrom
Conversation
aec8cee to
cdaed45
Compare
3 tasks
cdaed45 to
2cc7761
Compare
Member
Author
|
/test |
2cc7761 to
afbdd26
Compare
Member
Author
|
/test |
afbdd26 to
4c36361
Compare
Member
Author
|
/test |
joamaki
approved these changes
Dec 5, 2025
The refactored LB control plane for LRP missed the pod readiness check from the earlier LRP manager implementation. As a result, this led to creation of local-redirect entries when pod backends weren't ready to service traffic. Fixes: 5a289d5 ("experimental: Implement handling of LocalRedirectPolicies") Fixes: cilium#43080 Signed-off-by: Aditi Ghag <aditi@cilium.io>
4c36361 to
7ecc741
Compare
Member
Author
|
/test |
3 tasks
|
Hi , I originally reported this under issue #43080 and it was fixed in issue #43095 , that is listed in the release notes for 1.18.6 but the issue remains in 1.18.6 (its gone from 1.19.pre-4.| @aditighag @joamaki Looking at the backport PR #43425 that has a message Dropped #43095 : multiple issue, set.go in pkg/labels do not exist in v1.18, same for types.Match So this doesn't look like its made it to 1.18.6! |
Member
|
yep, thanks for the ping! Looks like the backport was dropped from #43425, but still triggered a label update here. So we'd still need a manual backport to |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #43080