Fix GC of possible duplicated identities in kvstore mode#43287
Merged
giorio94 merged 2 commits intocilium:mainfrom Dec 12, 2025
Merged
Fix GC of possible duplicated identities in kvstore mode#43287giorio94 merged 2 commits intocilium:mainfrom
giorio94 merged 2 commits intocilium:mainfrom
Conversation
In preparation for addressing a bug affecting this logic, and validating the fix, let's scaffold a basic test to cover the [RunGC] function. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Currently, the [RunGC] logic does not delete duplicated identities (i.e., pointing to the same labels), as long as at least one of them is actually used. Although duplicated identities should never occur in kvstore mode thanks to locking, this has been observed happening in the wild, and it is better to be robust in this case as well. Hence, let's fine tune the GC logic to consider a given identity as used only if it has any associated secondary key that also matches the actual ID. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Member
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the [RunGC] logic does not delete duplicated identities (i.e., pointing to the same labels), as long as at least one of them is actually used. Although duplicated identities should never occur in kvstore mode thanks to locking, this has been observed happening in the wild, and it is better to be robust in this case as well. Hence, let's fine tune the GC logic to consider a given identity as used only if it has any associated secondary key that also matches the actual ID.