Skip to content

.github/workflows: remove auto-requested reviewers#42952

Merged
aanm merged 1 commit intomainfrom
pr/fix-remove-review
Nov 25, 2025
Merged

.github/workflows: remove auto-requested reviewers#42952
aanm merged 1 commit intomainfrom
pr/fix-remove-review

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Nov 24, 2025

If reviews were requested by renovate or the auto-committer it means it happened on a auto-approve PR and therefore we don't need to request reviews from anyone.

If reviews were requested by renovate or the auto-committer it means it
happened on a auto-approve PR and therefore we don't need to request
reviews from anyone.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested a review from a team as a code owner November 24, 2025 09:53
@aanm aanm requested a review from joestringer November 24, 2025 09:53
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Nov 24, 2025
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Nov 24, 2025

/test

@aanm aanm enabled auto-merge November 24, 2025 09:53
@joestringer
Copy link
Copy Markdown
Member

We've hit some problems recently where renovate has been bumping dependencies we're not ready to adopt, for instance bumping LLVM major versions on stable branches. Are we ready to fully decouple reviews from humans in this area now?

We might also want to think about formalizing the triage process for these PRs if no-one is auto-assigned. I occasionally take a look at renovate PRs but it's not super obvious to me what happens if the PR gets stuck on CI for instance.

@aanm
Copy link
Copy Markdown
Member Author

aanm commented Nov 25, 2025

We've hit some problems recently where renovate has been bumping dependencies we're not ready to adopt, for instance bumping LLVM major versions on stable branches. Are we ready to fully decouple reviews from humans in this area now?

Oh, I didn't know this. Then it should be a matter of updating renovate configuration to take into account those constrains.

We might also want to think about formalizing the triage process for these PRs if no-one is auto-assigned. I occasionally take a look at renovate PRs but it's not super obvious to me what happens if the PR gets stuck on CI for instance.

The reason for automating PRs is that we don't need to look at them. Me and Julian usually check the PRs on a weekly basis and see they are getting stuck for more than a week. If that happens I ping directly the owners of that dependency.

@aanm aanm added this pull request to the merge queue Nov 25, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 25, 2025
Merged via the queue into main with commit f4bdd95 Nov 25, 2025
81 checks passed
@aanm aanm deleted the pr/fix-remove-review branch November 25, 2025 17:06
@aanm aanm added needs-backport/1.16 needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Dec 15, 2025
@Artyop Artyop mentioned this pull request Dec 15, 2025
1 task
@Artyop Artyop added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Dec 15, 2025
@Artyop Artyop mentioned this pull request Dec 15, 2025
1 task
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.16 backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Dec 15, 2025
@Artyop Artyop mentioned this pull request Dec 18, 2025
4 tasks
@Artyop Artyop added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Dec 18, 2025
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Dec 19, 2025
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

4 participants