Add periodic resync for secret-sync controller#42414
Merged
youngnick merged 1 commit intocilium:mainfrom Dec 8, 2025
Merged
Conversation
a935b8f to
78387bc
Compare
Contributor
Author
|
/test |
mhofstetter
reviewed
Nov 3, 2025
mhofstetter
reviewed
Nov 3, 2025
Member
mhofstetter
left a comment
There was a problem hiding this comment.
btw: i suggest to update the release note a little bit (adding operator & k8s context - because we have more than this "secret sync")
The Secret synchronization process now has a configurable resynchronization period.
->
operator: the K8s Secret synchronization process now has a configurable resynchronization period.
Contributor
|
Why default to zero? I understand this is the internal behavior, but nobody could possibly be relying on this, right, since restarting the operator process will resynchronize regardless? |
78387bc to
9d5419c
Compare
d218a1e to
a552c87
Compare
Contributor
Author
|
/test |
a552c87 to
db155f7
Compare
Contributor
Author
|
/test |
squeed
reviewed
Dec 4, 2025
This commit adds a periodic resync for the secret-sync controller. Each synchronized Secret will be resynced once per hour, with some jitter added. This allows users who might sometimes see issues with the secret-sync process to be confident that secrets will be kept up to date. Signed-off-by: Nick Young <nick@isovalent.com>
db155f7 to
0a9c419
Compare
Contributor
Author
|
/test |
qmonnet
approved these changes
Dec 4, 2025
Member
qmonnet
left a comment
There was a problem hiding this comment.
The no-longer-existent changes to docs look good to me 🙃
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a configurable setting that specifies how often the secret-sync process will resync all synchronized Secrets.
This setting defaults to
0, which means they will never be resynchronized. This is so there is no behavior change introduced.This allows users who might sometimes see issues with the secret-sync process to be confident that secrets will be kept up to date.