cmapisrv/test: miscellaneous fixes to the ciliumidentities script test#43372
Merged
giorio94 merged 1 commit intocilium:mainfrom Dec 16, 2025
Merged
cmapisrv/test: miscellaneous fixes to the ciliumidentities script test#43372giorio94 merged 1 commit intocilium:mainfrom
giorio94 merged 1 commit intocilium:mainfrom
Conversation
It appears that the ciliumidentities.txtar test is affected by two issues. First, the update performed at line 19 is ineffective, because none of the security labels contain the 'foo' token. Second, the namespace labels of the second identity are inconsistent. Let's get them fixed, and update the namespace labels to be different between the two identities. Fixes: 1d8c53f ("test/cmapisrv: add initial battery of script tests") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Member
Author
|
/test |
8 tasks
MrFreezeex
approved these changes
Dec 16, 2025
Member
MrFreezeex
left a comment
There was a problem hiding this comment.
Nice catch, thanks!
The image build broke so you might need to push force to retrigger the CI correctly 😅
Member
Author
Yeah, it failed twice in a row, maybe there's an outage somewhere 😢 Let's see if the third time is the lucky one 🤞 |
Member
Author
|
/test |
anubhabMajumdar
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that the ciliumidentities.txtar test is affected by two issues. First, the update performed at line 19 is ineffective, because none of the security labels contain the 'foo' token. Second, the namespace labels of the second identity are inconsistent. Let's get them fixed, and update the namespace labels to be different between the two identities.