Skip to content

pacific: cephadm: Batch backport March (2)#40135

Merged
liewegas merged 151 commits intoceph:pacificfrom
liewegas:cephadm-march-2-pacific
Mar 16, 2021
Merged

pacific: cephadm: Batch backport March (2)#40135
liewegas merged 151 commits intoceph:pacificfrom
liewegas:cephadm-march-2-pacific

Conversation

@liewegas
Copy link
Member

@liewegas liewegas commented Mar 15, 2021

#39699 flake8
(lots of trivial conflicts around whitespace)
#39823 remove mirror code
#39825 alias rgw-nfs -> nfs
#39726 upgrade multiple osds in parallel
#39639 existing osds
#39955 do not prime service cache on config
#39924 prevent traceback on invalid osd id
#39599 device scan w/ lsm
#39541 config checks
#39875 rewrite adoption.rst
#39789 add prompts to adoption.rst
#39916 rewrite preparation in adtopion.rst
#39930 rewrite 'adtopion process'
#39877 simplify handling for rgw
#39619 rm injected argv
#39640 cephfs-mirror
#39677 add iscsi and nfs to upgrade
#39979 count-per-host
#40071 fix auth get-or-create
#39857 remove duplicate labels when adding a host
#39896 apt uses apt not dnf
#39932 update section on custom config
#40008 note on nfs3 deprecation
#40034 fix iscsu upgrade test
#40046 deploy legacy r.z on upgrade
#40042 add back rhel+centos kubic
#40140 mgr/cephadm: fix 'auth caps' fallback

  • one hunk from aca45d7 to bring src/pybind/mgr/cephadm fully in sync
  • various commits adding type annotations to mgr_module and prometheus, which allowed me to avoid some conflicts

@liewegas liewegas requested a review from a team March 15, 2021 20:57
@liewegas liewegas requested review from a team as code owners March 15, 2021 20:57
@liewegas liewegas requested review from avanthakkar, nizamial09 and votdev and removed request for a team March 15, 2021 20:57
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 78916a4)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 8187eb9)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 75cf5fc)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 15e4b78)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 0b3943a)
adk3798 and others added 26 commits March 16, 2021 07:56
Fixes: https://tracker.ceph.com/issues/49626

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 030fb9d)
Adjusted so Ubuntu command uses 'apt' and added Fedora since that uses 'dnf'.

(cherry picked from commit ffc08b9)
introduced by:
cd79c99

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit b58b0de)
`reconfig` can be used to apply a change to either
the tls/ssl cert or a custom configuration file (j2)

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit b4b6f35)
a restart of the mgr does not appear to be necessary
after a `ceph config-key set ...`

Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit 9441d66)
Signed-off-by: Michael Fritch <mfritch@suse.com>
(cherry picked from commit a52bd99)
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 0a139c1)
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 6ccc3d8)
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 04a3d4c)
Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit dbdd4d4)
This hunk is from aca45d7, a much
larger change in master that added type annotations all over the place.
It just brings src/pybind/mgr/cephadm fully in sync with master.

Signed-off-by: Sage Weil <sage@newdream.net>
The first get-or-create attempt also needs to tolerate failure.

Fixes: 8ceea19

Signed-off-by: Sage Weil <sage@newdream.net>
(cherry picked from commit 19c7523)
Introduces metric `prometheus_collect_duration_seconds` for the time it
takes the Prometheus manager module to collect all the metrics.

```
ceph_prometheus_collect_duration_seconds_sum{method="get_health"} 0.0002613067626953125
ceph_prometheus_collect_duration_seconds_sum{method="get_pool_stats"} 0.0018298625946044922
ceph_prometheus_collect_duration_seconds_sum{method="get_df"} 0.0005767345428466797
ceph_prometheus_collect_duration_seconds_sum{method="get_fs"} 0.0010402202606201172
ceph_prometheus_collect_duration_seconds_sum{method="get_quorum_status"} 0.0007524490356445312
ceph_prometheus_collect_duration_seconds_sum{method="get_mgr_status"} 0.0035364627838134766
ceph_prometheus_collect_duration_seconds_sum{method="get_pg_status"} 0.00021266937255859375
ceph_prometheus_collect_duration_seconds_sum{method="get_osd_stats"} 0.0018737316131591797
ceph_prometheus_collect_duration_seconds_sum{method="get_metadata_and_osd_status"} 0.0032796859741210938
ceph_prometheus_collect_duration_seconds_sum{method="get_num_objects"} 0.00011086463928222656
ceph_prometheus_collect_duration_seconds_sum{method="get_rbd_stats"} 0.00036144256591796875
ceph_prometheus_collect_duration_seconds_count{method="get_health"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_pool_stats"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_df"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_fs"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_quorum_status"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_mgr_status"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_pg_status"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_osd_stats"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_metadata_and_osd_status"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_num_objects"} 1.0
ceph_prometheus_collect_duration_seconds_count{method="get_rbd_stats"} 1.0
```

Fixes: https://tracker.ceph.com/issues/46703

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit 801d3f6)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 58fd057)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit e69aad6)

# Conflicts:
#	src/pybind/mgr/tox.ini
  - pacific telemetry not in tox.ini
so we don't need to worry about escaping the backslash anymore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 734dd75)
for the explanation why we should add a line break before a binary
operator. see
https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 5dd9db9)
update to adapt the type annotation of MgrModule.list_servers()

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 19abd1e)

# Conflicts:
#	src/pybind/mgr/telemetry/module.py
  - drop telemetry portion
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 3b9ecd1)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit f92aa2f)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 7f43844)

# Conflicts:
#	src/mypy.ini
  - surrounding modules are in master but not pacific
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit 806ef8a)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 48b70f2)
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit 0fdbdb4)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit b67e434)
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 3649ecf)
@liewegas liewegas force-pushed the cephadm-march-2-pacific branch from 60d71ab to a601b2e Compare March 16, 2021 13:35
@liewegas
Copy link
Member Author

@liewegas liewegas merged commit a79b66e into ceph:pacific Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants