doc/cephadm: rewrite "preparation" in adoption.rst#39916
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Mar 15, 2021
Merged
Conversation
sebastian-philipp
suggested changes
Mar 9, 2021
doc/cephadm/adoption.rst
Outdated
Comment on lines
+28
to
+29
| with any release of Ceph that is Octopus (15.2.z) or later, inclusive. For | ||
| example, ``docker.io/ceph/ceph:v15.2.0`` will work. The latest stable |
Contributor
There was a problem hiding this comment.
We should probably recommend the latest stable release at this point.
Contributor
Author
There was a problem hiding this comment.
I'm going to take out the sentence that mentions the specific release. That should help to future-proof this part of the docs.
66f162a to
34e6371
Compare
sebastian-philipp
approved these changes
Mar 11, 2021
sebastian-philipp
suggested changes
Mar 11, 2021
Contributor
sebastian-philipp
left a comment
There was a problem hiding this comment.
the title of the commit should start with doc/cephadm:
Contributor
Author
Ach. So it should. |
This rewrites the "Adoption" section of preparation.rst in the Cephadm manual. Signed-off-by: Zac Dover <zac.dover@gmail.com>
34e6371 to
2a47caf
Compare
sebastian-philipp
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the "Adoption" section of
preparation.rst in the Cephadm manual.
Signed-off-by: Zac Dover zac.dover@gmail.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox