mgr/cephadm:Enable cephadm device scan to use libstoragemgmt#39599
mgr/cephadm:Enable cephadm device scan to use libstoragemgmt#39599sebastian-philipp merged 2 commits intoceph:masterfrom pcuzner:cephadm-with-lsm
Conversation
|
Seems okayish to me with caveats, as I said to Paul in private email; it seems to me that we ought to, at a minimum:
I had also suggested looking for a way to use sg directly (or more likely through libsgutils2.so.2), but I can't find any healthy Python bindings, or even documentation (other than the header files). The only advantage is trial-by-fire; sg has been through a lot of buggy hardware, and with SCSI that's a lot of hardware. I know it may seem overcautious, but the consequences are large, and the affected hardware is really unknown. We've seen one instance but that definitely doesn't mean there aren't others (and I've got past experience at Sun with a lot of others). |
|
@dmick the test could even be cephadm itself - i.e. cephadm ceph-volume inventory --with-lsm --format=json |
|
Yeah, probably so |
If you want the benefit of trial-by-fire with regards to sg utils I believe you need to leverage the sg command line utilities. For example, looking at the header files for issuing an inquiry command |
|
@tasleson good point. Perhaps opt-in with libstoragemgmt is our safest option at this point. |
|
@sebastian-philipp where should this be documented? I was thinking cephadm/osd.rst ? |
yeah, maybe somewhere around https://docs.ceph.com/en/latest/cephadm/osd/#list-devices ? |
Using libstoragemgmt (LSM) in ceph-volume was disabled by default, (nov 2020) which meant cephadm's inventory never had a way to request the LSM data. This patch adds a module option called 'device_enhanced_scan' (bool), that if set will append the --with-lsm parameter to the ceph-volume inventory call. Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
Updates the cephadm osd documentation to include details about including integration with libstoragement - including the potential hardware issues that may arise. Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
|
@sebastian-philipp @dmick docs added to cover the benefit and potential issues that turning libstoragemgmt introduces. |
Using libstoragemgmt (LSM) in ceph-volume was disabled by default,
(nov 2020) which meant cephadm's inventory never had a way to
request the LSM data. This patch adds a module option called
'device_enhanced_scan' (bool), that if set will append the
--with-lsm parameter to the ceph-volume inventory call.
Signed-off-by: Paul Cuzner pcuzner@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox