ceph-volume inventory: make libstoragemgmt data retrieval optional#38149
Merged
jan--f merged 1 commit intoceph:masterfrom Nov 26, 2020
Merged
ceph-volume inventory: make libstoragemgmt data retrieval optional#38149jan--f merged 1 commit intoceph:masterfrom
jan--f merged 1 commit intoceph:masterfrom
Conversation
Contributor
Author
|
jenkins test docs |
44e1672 to
ddfe393
Compare
Contributor
|
please run the cephadm suite as well. |
sebastian-philipp
approved these changes
Nov 18, 2020
Contributor
Author
|
jenkins test docs |
badone
approved these changes
Nov 18, 2020
Contributor
|
We should probably document this prominently in the release notes to try and avoid the situation where people with older controllers are hit by the issue described in the tracker. |
Contributor
|
relates to #37644 which is not yet backported |
Contributor
Author
|
jenkins test ceph-volume all |
Contributor
Author
|
jenkins test ceph-volume tox |
Member
|
jenkins retest this please |
ddfe393 to
45ae86c
Compare
Default to not retrieving libstoragemgmt data since it seems this can cause serious issues on older hardware. Safest way is to only retrieve lsm data when the user opts in.. Fixes: https://tracker.ceph.com/issues/48270 Signed-off-by: Jan Fajerski <jfajerski@suse.com>
45ae86c to
b29a54d
Compare
Contributor
Author
|
jenkins test ceph-volume all |
Contributor
Author
|
jenkins test ceph-volume tox |
dmick
approved these changes
Nov 26, 2020
Member
dmick
left a comment
There was a problem hiding this comment.
lgtm. I continue to try to advise the libstoragemgmt team in libstorage/libstoragemgmt#442 for a real fix to the Areca's problem. From the nature of various codebases using SCSI commands, I suspect these are not the only fussy devices.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to not retrieving libstoragemgmt data since it seems this can
cause serious issues on older hardware. Safest way is to only retrieve this when the user opts in.
Fixes: https://tracker.ceph.com/issues/48270
Signed-off-by: Jan Fajerski jfajerski@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox