mgr/orchestrator: set lsm_data to default of Dict type#37644
Merged
jschmid1 merged 1 commit intoceph:masterfrom Oct 19, 2020
Merged
mgr/orchestrator: set lsm_data to default of Dict type#37644jschmid1 merged 1 commit intoceph:masterfrom
lsm_data to default of Dict type#37644jschmid1 merged 1 commit intoceph:masterfrom
Conversation
similar to handling of `sys_api`, convert a NoneType to a Dict Fixes: https://tracker.ceph.com/issues/47841 Signed-off-by: Michael Fritch <mfritch@suse.com>
a61679b to
39512f9
Compare
jan--f
approved these changes
Oct 13, 2020
Contributor
jan--f
left a comment
There was a problem hiding this comment.
One nit pick to simplify a minute amount, but otherwise lgtm
| lvs=None, # type: Optional[List[str]] | ||
| device_id=None, # type: Optional[str] | ||
| lsm_data={}, # type: Dict[str, Dict[str, str]] | ||
| lsm_data=None, # type: Optional[Dict[str, Dict[str, str]]] |
Contributor
There was a problem hiding this comment.
This is a nit pick for sure, but wouldn't it make sense to keep lsm_data={} if only for being able to drop Optional[] from the type signature? I don't see how this can ever be None
Contributor
Author
There was a problem hiding this comment.
I think we want to avoid using a mutable default? The NoneType value was caused by going between subinterpreters ...
This was referenced Nov 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to handling of
sys_api, convert a NoneType to a DictFixes: https://tracker.ceph.com/issues/47841
Signed-off-by: Michael Fritch mfritch@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox