mgr/cephadm: remove duplicate labels when adding a host#39857
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Mar 12, 2021
Merged
mgr/cephadm: remove duplicate labels when adding a host#39857sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
mgfritch
approved these changes
Mar 5, 2021
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
works! but somewhat wonder if the HostSpec class should be doing the handling
jmolmo
approved these changes
Mar 8, 2021
Member
jmolmo
left a comment
There was a problem hiding this comment.
I like a lot the way to avoid the duplicate label!!!
sebastian-philipp
suggested changes
Mar 8, 2021
Fixes: https://tracker.ceph.com/issues/49626 Signed-off-by: Adam King <adking@redhat.com>
Contributor
Author
|
changed this to remove duplicates in HostSpec from/to json functions rather than in the add host command. |
Contributor
|
Lots of errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/49626
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox