mgr/cephadm: prevent traceback when invalid osd id passed to 'orch osd rm stop'#39924
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Mar 10, 2021
Merged
Conversation
…d rm stop' orch osd rm exepcts a str that can be converted to an int passed to it if the user passed something that cant be converted it shows a traceback catching the ValueError prevents this traceback. Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
mgfritch
approved these changes
Mar 9, 2021
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orch osd rm expects a str that can be converted to an int passed to it
if the user passed something that cant be converted it shows a traceback
catching the ValueError prevents this traceback.
Fixes: https://tracker.ceph.com/issues/49659
Signed-off-by: Daniel Pivonka dpivonka@redhat.com