Skip to content

cephadm: introduce flake8 and flake8-quotes#39699

Merged
sebastian-philipp merged 40 commits intoceph:masterfrom
mgfritch:cephadm-bin-flake8-quotes
Mar 4, 2021
Merged

cephadm: introduce flake8 and flake8-quotes#39699
sebastian-philipp merged 40 commits intoceph:masterfrom
mgfritch:cephadm-bin-flake8-quotes

Conversation

@mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Feb 25, 2021 •
edited
Loading

  • Add flake8 as a linter for bin/cephadm
  • Add flake8-quotes to standardize on a ' chars

Replaces: #39576

Signed-off-by: Michael Fritch mfritch@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@mgfritch mgfritch requested a review from a team as a code owner February 25, 2021 15:16
@mgfritch mgfritch mentioned this pull request Feb 25, 2021
Closed
3 tasks
@sebastian-philipp
Copy link
Contributor

sebastian-philipp commented Feb 25, 2021

you have a chmod on cephadm in this PR

@mgfritch mgfritch force-pushed the cephadm-bin-flake8-quotes branch from b6e9976 to 4a78a5b Compare February 26, 2021 21:50
@mgfritch
Copy link
Contributor Author

mgfritch commented Feb 26, 2021 •
edited
Loading

you have a chmod on cephadm in this PR

ooops, thanks for catching this! looks like it was actually introduced by #39576

@mgfritch
Copy link
Contributor Author

mgfritch commented Feb 26, 2021

jenkins test make check

@jmolmo jmolmo mentioned this pull request Mar 2, 2021
Closed
3 tasks
jmolmo
jmolmo approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@jmolmo jmolmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Michael!!!

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@mgfritch mgfritch force-pushed the cephadm-bin-flake8-quotes branch from 4a78a5b to 89fd6aa Compare March 2, 2021 21:03
@mgfritch mgfritch changed the title cephadm: introduce flake8-quotes cephadm: introduce flake8 and flake8-quotes Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@mgfritch mgfritch force-pushed the cephadm-bin-flake8-quotes branch from 89fd6aa to d6de2ca Compare March 3, 2021 16:32
mgfritch added 11 commits March 3, 2021 09:33
@mgfritch
cephadm: introduce flake8
78916a4 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: over-indented (E117)
8187eb9 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line under-indented for hanging indent (E121)
75cf5fc 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line missing indentation or outdented (E122)
15e4b78 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: ... does not match indentation of opening bracket's line (E123)
0b3943a 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: closing bracket does not match visual indentation (E124)
91b54fc 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line with same indent as next logical line (E125)
0d57f54 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line over-indented for hanging indent (E126)
fa2b17c 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line over-indented for visual indent (E127)
460e6e8 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line under-indented for visual indent (E128)
4611df9 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line unaligned for hanging indent (E131)
5ba2b30 
Signed-off-by: Michael Fritch <mfritch@suse.com>
mgfritch added 24 commits March 3, 2021 09:33
@mgfritch
cephadm: multiple spaces after ',' (E241)
d2bb74a 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: unexpected spaces around keyword / parameter equals (E251)
d47b26d 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: at least two spaces before inline comment (E261)
6d93739 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: block comment should start with '# ' (E265)
20c5f3d 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: too many leading '#' for block comment (E266)
3dcb56e 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 1 blank line, found 0 (E301)
858b55c 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 2 blank lines, found 1 (E302)
dea7798 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: too many blank lines (E303)
f1af846 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 2 blank lines after end of function or class (E305)
cf9e974 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 1 blank line before a nested definition (E306)
6c8ea9f 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: module level import not at top of file (E402)
9bbb359 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: statement ends with a semicolon (E703)
6237df7 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: do not use bare 'except' (E722)
8eb4c38 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: ambiguous variable name 'l' (E741)
c587016 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: 'select' imported but unused (F401)
bb03318 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: local variable 'e' is assigned to but never used (F841)
ec56db1 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: trailing whitespace (W291)
1870056 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: blank line contains whitespace (W293)
06e02b7 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: line break after binary operator (W504)
7ac0479 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: introduce flake8-quotes
49f25f5 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: Remove bad quotes (Q000)
6ca31b9 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: Remove bad quotes from multiline string (Q001)
3b8656d 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: Change outer quotes to avoid escaping inner quotes (Q003)
55788a0 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: fixup alrady -> already
d6323e3 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch mgfritch force-pushed the cephadm-bin-flake8-quotes branch from d6de2ca to d6323e3 Compare March 3, 2021 16:33
@mgfritch
Copy link
Contributor Author

mgfritch commented Mar 3, 2021 •
edited
Loading

https://pulpito.ceph.com/mgfritch-2021-03-02_23:06:05-rados:cephadm-wip-mgfritch-testing-2021-03-02-1408-distro-basic-smithi/

Failure:
https://tracker.ceph.com/issues/49590

@sebastian-philipp sebastian-philipp merged commit 7744777 into ceph:master Mar 4, 2021
@mgfritch mgfritch deleted the cephadm-bin-flake8-quotes branch March 4, 2021 15:00
@liewegas liewegas mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmolmo jmolmo jmolmo approved these changes

Assignees

No one assigned

Labels

build/ops cephadm wip-mgfritch-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgfritch @sebastian-philipp @jmolmo