Skip to content

cephadm: introduce flake8#39576

Closed
mgfritch wants to merge 35 commits intoceph:masterfrom
mgfritch:cephadm-bin-flake8
Closed

cephadm: introduce flake8#39576
mgfritch wants to merge 35 commits intoceph:masterfrom
mgfritch:cephadm-bin-flake8

Conversation

@mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Feb 19, 2021

Adds flake8 as a linter for bin/cephadm

Signed-off-by: Michael Fritch mfritch@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@mgfritch mgfritch requested a review from a team as a code owner February 19, 2021 15:12
liewegas
liewegas reviewed Feb 19, 2021
View reviewed changes
liewegas
liewegas reviewed Feb 19, 2021
View reviewed changes
src/cephadm/cephadm

# Default container images -----------------------------------------------------
DEFAULT_IMAGE = 'docker.io/ceph/daemon-base:latest-master-devel'
DEFAULT_IMAGE_IS_MASTER = True
Copy link
Member

@liewegas liewegas Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth standardizing on ' or "?

Copy link
Contributor Author

@mgfritch mgfritch Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of that, personally I prefer ' ..

Copy link
Contributor Author

@mgfritch mgfritch Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liewegas #39699

@mgfritch mgfritch mentioned this pull request Feb 25, 2021
Merged
3 tasks
@mgfritch
cephadm: introduce flake8
af5fbbc 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: over-indented (E117)
9347b95 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line under-indented for hanging indent (E121)
da4c0f9 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line missing indentation or outdented (E122)
6385823 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: ... does not match indentation of opening bracket's line (E123)
c2cd218 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: closing bracket does not match visual indentation (E124)
3cf3104 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line over-indented for hanging indent (E126)
054b355 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line over-indented for visual indent (E127)
a02c745 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line under-indented for visual indent (E128)
01fff42 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: continuation line unaligned for hanging indent (E131)
6be2657 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: whitespace after '{' (E201)
62f2a5d 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: whitespace before ':' (E203)
292d5c6 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: missing whitespace around operator (E225)
e574b24 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: missing whitespace around arithmetic operator (E226)
ea51907 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: missing whitespace after ':' (E231)
5fced9d 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: multiple spaces after ',' (E241)
c1ea08e 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: unexpected spaces around keyword / parameter equals (E251)
1b33bd3 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: at least two spaces before inline comment (E261)
58819e4 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: block comment should start with '# ' (E265)
91c4205 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: too many leading '#' for block comment (E266)
b7e2d9f 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 1 blank line, found 0 (E301)
147750b 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 2 blank lines, found 1 (E302)
8b6849a 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: too many blank lines (E303)
6b7e4b1 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 2 blank lines after end of function or class (E305)
eca1d63 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: expected 1 blank line before a nested definition (E306)
4174c48 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: module level import not at top of file (E402)
43a1b1f 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: statement ends with a semicolon (E703)
1c4f5fc 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: do not use bare 'except' (E722)
c905fea 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: ambiguous variable name 'l' (E741)
ad34bae 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: 'select' imported but unused (F401)
686dc51 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: local variable 'e' is assigned to but never used (F841)
dc1f72f 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: trailing whitespace (W291)
b5f00dc 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: blank line contains whitespace (W293)
94de5c6 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: line break after binary operator (W504)
9487111 
Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
cephadm: fix mypy error
b02acbc 
cephadm: note: In function "list_daemons":
cephadm:4532: error: List item 3 has incompatible type "List[Any]"; expected "str"
Found 1 error in 1 file (checked 1 source file)

Signed-off-by: Michael Fritch <mfritch@suse.com>
@mgfritch
Copy link
Contributor Author

mgfritch commented Feb 26, 2021

jenkins test make check

@jmolmo
Copy link
Member

jmolmo commented Mar 2, 2021

It seems that this pr can be superseded by #39699. I am wrong?

@github-actions
Copy link

github-actions bot commented Mar 2, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@mgfritch
Copy link
Contributor Author

mgfritch commented Mar 2, 2021

It seems that this pr can be superseded by #39699. I am wrong?

closing in favor of using a single PR (#39699)

@mgfritch mgfritch closed this Mar 2, 2021
@mgfritch mgfritch deleted the cephadm-bin-flake8 branch March 2, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liewegas liewegas liewegas left review comments

@jmolmo jmolmo Awaiting requested review from jmolmo

Assignees

No one assigned

Labels

build/ops cephadm cleanup needs-rebase wip-mgfritch-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgfritch @jmolmo @liewegas