… (joomla#12290)

* Cleanups, fixes and a bit of optimizations for site/components batch #1

- com_ajax
- com_banners
- com_config
Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Ch-Ch-Changes!

* Removed the query changes

* Fix for wrong merge resolve

…otes-in-administrator-no-1

Replace unnecessary double quotes in administrator #1

- removed senseless statements
- one case correction
- one loop optimization
- removed a closing tag

Some improvements in tests #1:

)

* Update site.php

* Update site.php

* Update site.php

* Update site.php

* Move unset into the else condition

Rework toolbar

add active class

eliminate inline scripts, CSP strict mode

* Fixed callable call in loop termination condition

* Fixed non-optimal regular expression

* Shortened syntax for applied operations

* Don't use strlen() to check if string is empty.

* Reverted preg changes. Look into those later again.

* Replaced call_user_func_array() with call_user_func()

* Merge unset() calls

* Replaced old intval() call with modern typecasting

* Optimize away substr() as index-based access

* Replace some cases of substr() with strpos()

* Replace some stristr() with stripos()

* Replace is_null() with null === ...

* Removed unnecessary ternary operators

* Fix for Juri...

* Revert some changes for ... PHP5.3 compatibility

* Make travis happy ....

* Make codesniffer happy...

* DYC!

* Optimize non-optimal if conditions.

* codsniffer...

* Inline one-time use variables

* Codesniffer...

* Flipped comparisons
`null === ...`  to Joomla Style `... === null`
`null !== ...`  to Joomla Style `... !== null`

* Flipped comparisons
`false !== ...`  to Joomla Style `... !== falsel`

* Fix removal of ternary operator. Forgot inversion.

* More flipping of  comparisons ;)

* Removed another unnecessary set of ternary operators.

* Codesniffer...

* Type-safe comparisons on strings

* More type-safe comparisons

* Changes that occurred during PR discussion

* Remove some unnecessary parentheses

* Removed empty if-group and reversed condition

* Corrections on errors during merge (Conflict resolving)

* Missed one.

* Remove a parenthesis

* Changes according to reviewer's comment

* Revert change because of failure

* Changes according to reviewer's comment
+ a few more changes found last minute

* reversed change, though according to the method's doc that value should have been an integer...

* Hopefully fixed...

* Hopefully fixed...

* Re-apply some changes

* com_categories

* Update admin-category-modal.min.js

* oops, this is totally useless

* all the rest views that contain this deprecated code

Update master

Add missing string COM_PRIVACY_MSG_CONSENT_NO_CONSENT

Design action buttons upper toolbar

Added fade effect with transition after login and after logout in js

Update documentation link in docblock

…4.0-dev

Merge upstream/4.0-dev into angieradtke/admintemplate

* Fix the missing installer info

* Fix the template thumb images

* Fix missing language on style view

* Update Templates.php

* Update libraries/src/Installer/Installer.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update build/media_source/system/images/template_thumb.svg

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update build/media_source/system/images/template_thumb.svg

Co-authored-by: Brian Teeman <brian@teeman.net>

* Fix the thumb logic

* editor #1

* CS

* CS

* CS + fix logic

* Ensure the isMedia flag is correcly propageted

* Ooops, forgot the child creation functionality

From joomla#35879

* CS

* Update administrator/components/com_templates/tmpl/template/default_modal_child_body.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/components/com_templates/tmpl/template/default_modal_child_footer.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Fix the description for the child name

* Update administrator/components/com_templates/tmpl/template/default_media_folders.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/components/com_templates/tmpl/template/default_tree_media.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Fix copy/pasting doc blocks

* Child tmpl name === parentTmplName_childName

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update administrator/components/com_templates/src/View/Template/HtmlView.php

Co-authored-by: Brian Teeman <brian@teeman.net>

* CS

* Update administrator/components/com_templates/src/Service/HTML/Templates.php

Co-authored-by: Quy <quy@fluxbb.org>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>

* Bailout Early

* CS

* Don't throw warnings

* better conditianal

* More notices

* Fix the thumb paths

* Fix Fat FS lookups

* Fix the missing media folder for the child template

* don't echo the first slash on win OS

* .html is not in the allowed list. WOW

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/tmpl/template/default_modal_folder_body.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/tmpl/template/default_media_folders.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/tmpl/template/default.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/src/View/Template/HtmlView.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* Update administrator/components/com_templates/src/Model/TemplateModel.php

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>

* CS, proper media folder logic

* CS

* Meh

* Paths...

* better tree entry names

* Use current user name, current date for child

* Bug, file delete

* Fix upload

* Add a visual cue for parent/child

* Add buttons to switch between list views

@bembelimen's idea

* Wrong comments

* Clean up the child method

* PHP notice, use entry dir as the starting point

* Correct icon

* Undefined $isMedia Pfff

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Update administrator/components/com_templates/src/Controller/TemplateController.php

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

* Merge joomla#36011

* Remove a debug line

* Windows use / instead of \

* Winows double //

* Update administrator/language/en-GB/com_templates.ini

Co-authored-by: Brian Teeman <brian@teeman.net>

* double //

* b->strong

* rename modatl tittle //

* Update administrator/components/com_templates/tmpl/template/default_tree_media.php

Co-authored-by: Quy <quy@fluxbb.org>

* Update plugins/editors/tinymce/tinymce.php

Co-authored-by: Quy <quy@fluxbb.org>

* Switch the fallback icon

This has a Creative Commons Zero v1.0 Universal (CC0) license
and it was copied from: https://iconduck.com/search?query=xcode

* Update administrator/components/com_templates/src/View/Styles/HtmlView.php

Co-authored-by: Quy <quy@fluxbb.org>

* Update administrator/language/en-GB/com_templates.ini

Co-authored-by: Quy <quy@fluxbb.org>

* Update plugins/editors/tinymce/tinymce.php

Co-authored-by: Quy <quy@fluxbb.org>

* Update administrator/language/en-GB/com_templates.ini

Co-authored-by: Quy <quy@fluxbb.org>

* tabs

* Lang failsafe

* Update administrator/components/com_templates/tmpl/template/default_folders.php

Co-authored-by: Quy <quy@fluxbb.org>

Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

…a#36285)

…36284)

…oomla#36804)

Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`

…ssing null to type string (joomla#36795)

* [3.10] [PHP 8.1] fixes mod_tags_popular

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29`

* [3.10] [PHP 8.1] fixes mod_breadcrumbs

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21`

* Update mod_custom.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`

* [3.10] [PHP 8.1] Fixes mod_menu.php

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`

* [3.10] [PHP 8.1] mod_stats

* [3.10] [PHP 8.1] fixes mod_articles_archive.php

* [3.10] [PHP 8.1] mod_articles_categories.php

* [3.10] [PHP 8.1] fixes mod_articles_category

* [3.10] [PHP 8.1] fixes mod_articles_latest

* [3.10] [PHP 8.1] fixes mod_articles_news

* [3.10] [PHP 8.1] fixes mod_articles_popular

* [3.10] [PHP 8.1] fixes mod_banners

* [3.10] [PHP 8.1] fixes mod_feed

* [3.10] [PHP 8.1] fixes mod_footer

* [3.10] [PHP 8.1] fixes mod_languages

* [3.10] [PHP 8.1] fixes mod_random_image

* [3.10] [PHP 8.1] fixes mod_related_items

* [3.10] [PHP 8.1] fixes mod_syndicate

* [3.10] [PHP 8.1] fixes mod_tags_similar

* [3.10] [PHP 8.1] fixes mod_users_latest

* [3.10] [PHP 8.1] fixes mod_whosonline

* [3.10] [PHP 8.1] fixes mod_wrapper

* [3.10] [PHP 8.1] fixes admin mod_privacy_dashboard

* [3.10] [PHP 8.1] fixes admin mod_feed

* [3.10] [PHP 8.1] fixes admin mod_stats_admin

…tible (joomla#36794)

* [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115)

* [3.10] [PHP 8.1] Fixes protostar modules.php null string param

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47`

* [3.10] [PHP 8.1] Fixes beez modules.php null string param

Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`

…a#36792)

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`

…oomla#36799)

Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login

Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286`
and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`

…36777)

* [3.10] [PHP 8.1] Fix Editor Passing null to $string line 258

Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`

* [PHP 8.1] Editor in backend: Better fix for joomla#36777

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

…oomla#36773)

* [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string

Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383`

* [PHP 8.1] admin mod_menu: Slightly cleaner fix for joomla#36773

* [3.10] [PHP 8.1] Fixes com_finder/indexer/query

Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733`

* Better fix for joomla#36796 as suggested by @zero-24

…strpos() (joomla#36798)

* [3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in strpos()

Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124`

* [PHP 8.1] Better fix to avoid deprecation proposed by @zero-24

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Revert previous commit for different fix in mod_breadcrumbs/helper.php

* [PHP 8.1] Better fix for joomla#36798 mod_breadcrumbs with null link in last item

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

… is deprecated in components/com_ajax/ajax.php on line 39 (joomla#37007)

Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39

…#37384)

Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"

…src/Log/Log.php on line 387` (joomla#37009)

Fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Log/Log.php on line 387`

* Prevent Exception

If $parts is `null` this will throw an exception.

```count(): Argument #1 ($value) must be of type Countable|array, null given```

This can happen if the context is e.g. the default context `text` from the `Joomla\CMS\HTML\Helpers\Content::prepare()` function.

* Update fields.php

…of type string is deprecated (joomla#44876)

PHP Deprecated:  strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

Signed-off-by: BrianTeeman <brian@teeman.net>

PHP Deprecated:  strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

Signed-off-by: BrianTeeman <brian@teeman.net>