PHP 8.1: Fixes Deprecated: null to string in MailTemplate.php#37384
Merged
bembelimen merged 1 commit intojoomla:4.1-devfrom Mar 30, 2022
Merged
PHP 8.1: Fixes Deprecated: null to string in MailTemplate.php#37384bembelimen merged 1 commit intojoomla:4.1-devfrom
bembelimen merged 1 commit intojoomla:4.1-devfrom
Conversation
Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"
Contributor
|
I have tested this item ✅ successfully on 5ffd955 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37384. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 5ffd955 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37384. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37384. |
Contributor
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297Pull Request for Issue # none.
Summary of Changes
Obvious fix to avoid a default null (instead of empty string) passed to trim() which generates a deprecated warning in PHP 8.1.
Testing Instructions
Code review is enough imho.
To reproduce:
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No error.
Documentation Changes Required
None.