Changed bar graph to show entire timeline and arrow. · Pull Request #1 · beat/joomla-cms

ghost · 2013-06-13T14:17:30Z

Changed layout (explain in output instead of tooltip).

ghost · 2013-06-13T14:23:35Z

beat · 2013-06-13T14:44:04Z

Thanks @nonumber 👍
Also great that you found way to do pull requests, that will make life simpler to review and improve pull requests before merging, and your contribution better visible. :)

I will already merge the code cleanup commit, that I already reviewed. Thank you.

Regarding proposed changes on display in the second commit, and based on the nice screen-dumps above, here my comments/proposal:

Green color for Query Time: If we add color green to query times display (I tought of it, but didn't replace grey by green on purpose: Green means "ok", and it might be ok without being ok. Thus I have made the bar green to show that the actual execution time is OK. But It doesn't mean that the table is optimal. E.g. extensions table is missing index, but since it's usually for now small it is ok, but if it grows it is not ok anymore. Thus, if you insist on green, I would like to reserve it to queries taking less than 1 ms. In all cases, anything between 1 ms and 4 ms should remain grey zone: They might be ok depending on the query, but not ok for very simple queries.
The cluttered bargraph: Cool idea, I like it as an overview, but much less if it's between every query and the nice arrow also adds vertical spacing, and bars and arrow makes it more cluttered imho (at one point i was even thinking of overlaying the query time info and bar-graphs on same line to save a bit of scrolling between queries, which already take lots of scrolling without our additions):
- 2.a. What would you think of that compound nice "overview" bargraph only for the very first query (and leave 2nd-last as is?
- 2.b. And on that first query with all bars, it would be cool to be able to click on the bars (at least the red ones) to directly show the corresponding query (should be easy using anchors) ?

(i haven't reviewed the code yet, the above feedbacks are only on screendumps)

ghost · 2013-06-13T14:56:14Z

Maybe there should be a smarter implementation to set the colors. Like checking the length of the query and comparing that to the time. So that you don't look at total query time, but at (average) time per line/character.
The problem I saw with the all-in-one time line is that most queries take such a small place in the timeline that you can't really see them, let alone be able to click on them easily. Also the red ones.
We need to keep in mind why devs will be looking at the queries. I think in most cases to see which queries are the ones causing slowness. And which queries are duplicates.
So maybe we need to rethink stuff to make it easiest to spot those. See the most important info quickly and prominently. The EXPLAIN info - for instance - is pretty important, I think. So it should be in view, and not hidden in a tooltip.
Maybe an option to show/hide all these extra details... That way it is compact by default.
Not trying to make this PR larger than it should be (as this is a first step), but just thinking out loud.
Regarding my PR: take from it what you want and drop the rest :)

elkuku · 2013-06-13T15:04:34Z

and not hidden in a tooltip.

A small concern: I find myself scrolling in all possible directions (even right) trying to see the info displayed in the tooltips (pop overs).

I have implemented a small subset of this on a testing site using tabs, and it looks like this: http://tracker-joomla54.rhcloud.com

beat · 2013-06-13T15:08:11Z

@nonumber 👍 Thank you, I like your pull request, and will be certainly taking most of it, and actually try it out too.

As you could see, I've already switched bars of queries which have no index or filesorting from grey to orange color, as those are clearly not optimal. Guess what, a good part of Joomla queries turned from grey to orange :)
a. We can improve over time the automated analysis, but it is pretty hard to do such an analysis automatically in a reliable way beyond simple queries.
b. I would love to give duplicated queries a light orange background with a "This query has already been made and result should probably be cached.", as we already count duplicate queries.

@elkuku: I already tried improving this at end of debug.css, but the real fix should be that our templates don't give it a fixed width, so that those popovers always appear centered within screen.

beat · 2013-06-14T22:06:10Z

Ok, this pull request is now merged into last commit, so can close it. Thanks @nonumber 👍

Please see on the main pull request the issue with Safari and IE for sub-pixel widths roundings and TODO FIXME statements in the code corresponding to this. Hope you can find a CSS fix for that. :)

Pulled Ashwin's PR

Add Fixes suggested by Sebastian Bergmann

CodeStyle two whitespaces ;)

Making some database fields required

Shuffle around the php-encryption library setup

Allow to set an option to hide the Use default on helpsite field

Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383`

Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`

…tible Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115)

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47`

Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29`

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21`

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`

Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733`

Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286` and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`

…strpos() Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124`

Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login

Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`

…oomla#36804) Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`

…ssing null to type string (joomla#36795) * [3.10] [PHP 8.1] fixes mod_tags_popular Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29` * [3.10] [PHP 8.1] fixes mod_breadcrumbs Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21` * Update mod_custom.php Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18` * [3.10] [PHP 8.1] Fixes mod_menu.php Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23` * [3.10] [PHP 8.1] mod_stats * [3.10] [PHP 8.1] fixes mod_articles_archive.php * [3.10] [PHP 8.1] mod_articles_categories.php * [3.10] [PHP 8.1] fixes mod_articles_category * [3.10] [PHP 8.1] fixes mod_articles_latest * [3.10] [PHP 8.1] fixes mod_articles_news * [3.10] [PHP 8.1] fixes mod_articles_popular * [3.10] [PHP 8.1] fixes mod_banners * [3.10] [PHP 8.1] fixes mod_feed * [3.10] [PHP 8.1] fixes mod_footer * [3.10] [PHP 8.1] fixes mod_languages * [3.10] [PHP 8.1] fixes mod_random_image * [3.10] [PHP 8.1] fixes mod_related_items * [3.10] [PHP 8.1] fixes mod_syndicate * [3.10] [PHP 8.1] fixes mod_tags_similar * [3.10] [PHP 8.1] fixes mod_users_latest * [3.10] [PHP 8.1] fixes mod_whosonline * [3.10] [PHP 8.1] fixes mod_wrapper * [3.10] [PHP 8.1] fixes admin mod_privacy_dashboard * [3.10] [PHP 8.1] fixes admin mod_feed * [3.10] [PHP 8.1] fixes admin mod_stats_admin

…tible (joomla#36794) * [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115) * [3.10] [PHP 8.1] Fixes protostar modules.php null string param Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47` * [3.10] [PHP 8.1] Fixes beez modules.php null string param Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`

…a#36792) Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`

…oomla#36799) Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login

Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286` and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`

…36777) * [3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258` * [PHP 8.1] Editor in backend: Better fix for joomla#36777 Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

…oomla#36773) * [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383` * [PHP 8.1] admin mod_menu: Slightly cleaner fix for joomla#36773

@zero-24

* [3.10] [PHP 8.1] Fixes com_finder/indexer/query Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733` * Better fix for joomla#36796 as suggested by @zero-24

@bembelimen

* Fix the missing installer info * Fix the template thumb images * Fix missing language on style view * Update Templates.php * Update libraries/src/Installer/Installer.php Co-authored-by: Brian Teeman <brian@teeman.net> * Update build/media_source/system/images/template_thumb.svg Co-authored-by: Brian Teeman <brian@teeman.net> * Update build/media_source/system/images/template_thumb.svg Co-authored-by: Brian Teeman <brian@teeman.net> * Fix the thumb logic * editor #1 * CS * CS * CS + fix logic * Ensure the isMedia flag is correcly propageted * Ooops, forgot the child creation functionality From joomla#35879 * CS * Update administrator/components/com_templates/tmpl/template/default_modal_child_body.php Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/components/com_templates/tmpl/template/default_modal_child_footer.php Co-authored-by: Brian Teeman <brian@teeman.net> * Fix the description for the child name * Update administrator/components/com_templates/tmpl/template/default_media_folders.php Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/components/com_templates/tmpl/template/default_tree_media.php Co-authored-by: Brian Teeman <brian@teeman.net> * Fix copy/pasting doc blocks * Child tmpl name === parentTmplName_childName * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Brian Teeman <brian@teeman.net> * Update administrator/components/com_templates/src/View/Template/HtmlView.php Co-authored-by: Brian Teeman <brian@teeman.net> * CS * Update administrator/components/com_templates/src/Service/HTML/Templates.php Co-authored-by: Quy <quy@fluxbb.org> * Update administrator/components/com_templates/src/Controller/TemplateController.php Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com> * Bailout Early * CS * Don't throw warnings * better conditianal * More notices * Fix the thumb paths * Fix Fat FS lookups * Fix the missing media folder for the child template * don't echo the first slash on win OS * .html is not in the allowed list. WOW * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/src/Controller/TemplateController.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/tmpl/template/default_modal_folder_body.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/tmpl/template/default_media_folders.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/tmpl/template/default.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/src/View/Template/HtmlView.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/src/Controller/TemplateController.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * Update administrator/components/com_templates/src/Model/TemplateModel.php Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> * CS, proper media folder logic * CS * Meh * Paths... * better tree entry names * Use current user name, current date for child * Bug, file delete * Fix upload * Add a visual cue for parent/child * Add buttons to switch between list views @bembelimen's idea * Wrong comments * Clean up the child method * PHP notice, use entry dir as the starting point * Correct icon * Undefined $isMedia Pfff * Update administrator/components/com_templates/src/Controller/TemplateController.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Update administrator/components/com_templates/src/Controller/TemplateController.php Co-authored-by: Richard Fath <richard67@users.noreply.github.com> * Merge joomla#36011 * Remove a debug line * Windows use / instead of \ * Winows double // * Update administrator/language/en-GB/com_templates.ini Co-authored-by: Brian Teeman <brian@teeman.net> * double // * b->strong * rename modatl tittle // * Update administrator/components/com_templates/tmpl/template/default_tree_media.php Co-authored-by: Quy <quy@fluxbb.org> * Update plugins/editors/tinymce/tinymce.php Co-authored-by: Quy <quy@fluxbb.org> * Switch the fallback icon This has a Creative Commons Zero v1.0 Universal (CC0) license and it was copied from: https://iconduck.com/search?query=xcode * Update administrator/components/com_templates/src/View/Styles/HtmlView.php Co-authored-by: Quy <quy@fluxbb.org> * Update administrator/language/en-GB/com_templates.ini Co-authored-by: Quy <quy@fluxbb.org> * Update plugins/editors/tinymce/tinymce.php Co-authored-by: Quy <quy@fluxbb.org> * Update administrator/language/en-GB/com_templates.ini Co-authored-by: Quy <quy@fluxbb.org> * tabs * Lang failsafe * Update administrator/components/com_templates/tmpl/template/default_folders.php Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com> Co-authored-by: Phil E. Taylor <phil@phil-taylor.com> Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

@zero-24

…strpos() (joomla#36798) * [3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in strpos() Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124` * [PHP 8.1] Better fix to avoid deprecation proposed by @zero-24 Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Revert previous commit for different fix in mod_breadcrumbs/helper.php * [PHP 8.1] Better fix for joomla#36798 mod_breadcrumbs with null link in last item Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

… is deprecated in components/com_ajax/ajax.php on line 39 Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39

…src/Log/Log.php on line 387` Fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Log/Log.php on line 387`

… is deprecated in components/com_ajax/ajax.php on line 39 Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39

Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"

… is deprecated in components/com_ajax/ajax.php on line 39 (joomla#37007) Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39

…#37384) Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"

…src/Log/Log.php on line 387` (joomla#37009) Fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Log/Log.php on line 387`

Peter van Westen added 2 commits June 13, 2013 16:17

Changed bar graph to show entire timeline and arrow.

0b3544d

Changed layout (explain in output instead of tooltip).

Fixed some syntax

3ce3e7f

ghost mentioned this pull request Jun 13, 2013

Add SQL queries profiler in Debug zone with backtrace of call and EXPLAIN hovers joomla/joomla-cms#1237

Closed

beat closed this Jun 14, 2013

beat pushed a commit that referenced this pull request Jul 3, 2013

changing to default module style #1

6bed73b

beat pushed a commit that referenced this pull request Jul 3, 2013

removing commented code lines #1

4b481df

beat pushed a commit that referenced this pull request Sep 17, 2013

Merge pull request #1 from joomla-projects/feature-appstore-server

fa50b39

Pulled Ashwin's PR

beat pushed a commit that referenced this pull request Oct 20, 2014

Merge pull request #1 from javigomez/jlayout-systemtests

81cc5d0

Add Fixes suggested by Sebastian Bergmann

beat pushed a commit that referenced this pull request Feb 17, 2016

Merge pull request #1 from zero-24/patch-2

978e513

CodeStyle two whitespaces ;)

beat pushed a commit that referenced this pull request Feb 17, 2016

Merge pull request #1 from infograf768/patch-1

410e329

Making some database fields required

beat pushed a commit that referenced this pull request Feb 17, 2016

Merge pull request #1 from mbabker/encrypt-lib

78619fb

Shuffle around the php-encryption library setup

beat pushed a commit that referenced this pull request Feb 17, 2016

Merge pull request #1 from phproberto/ronak-8572

9b1b7a4

Allow to set an option to hide the Use default on helpsite field

beat added a commit that referenced this pull request Jan 21, 2022

[3.10] [PHP 8.1] Fix Editor Passing null to $string line 258

1a1f786

Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258`

beat added a commit that referenced this pull request Jan 22, 2022

Update mod_custom.php

87b04c4

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`

beat added a commit that referenced this pull request Jan 22, 2022

[3.10] [PHP 8.1] Fixes mod_menu.php

4a06d44

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`

beat added a commit that referenced this pull request Mar 26, 2022

PHP 8.1: Fixes Deprecated: null to string in MailTemplate.php

5ffd955

Fixes "Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Mail/MailTemplate.php on line 297"

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed bar graph to show entire timeline and arrow.#1

Changed bar graph to show entire timeline and arrow.#1
ghost wants to merge 2 commits intomysqlprofilingfrom
unknown repository

ghost commented Jun 13, 2013

Uh oh!

ghost commented Jun 13, 2013

Uh oh!

beat commented Jun 13, 2013

Uh oh!

ghost commented Jun 13, 2013

Uh oh!

elkuku commented Jun 13, 2013

Uh oh!

beat commented Jun 13, 2013

Uh oh!

beat commented Jun 14, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ghost commented Jun 13, 2013

Uh oh!

ghost commented Jun 13, 2013

Uh oh!

beat commented Jun 13, 2013

Uh oh!

ghost commented Jun 13, 2013

Uh oh!

elkuku commented Jun 13, 2013

Uh oh!

beat commented Jun 13, 2013

Uh oh!

beat commented Jun 14, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants