[3.10] [PHP 8.1] Fixing mod_search Passing null to type string#36792
Merged
zero-24 merged 1 commit intojoomla:3.10-devfrom Jan 23, 2022
Merged
[3.10] [PHP 8.1] Fixing mod_search Passing null to type string#36792zero-24 merged 1 commit intojoomla:3.10-devfrom
zero-24 merged 1 commit intojoomla:3.10-devfrom
Conversation
Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44`
Contributor
|
I have tested this item ✅ successfully on 60cbce4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792. |
Member
|
I have tested this item ✅ successfully on 60cbce4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792. |
Contributor
|
Merging thanks |
|
I have tested this item ✅ successfully on 60cbce4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36792. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # none
Summary of Changes
Fixes
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44Testing Instructions
Code review is enough.
But to reproduce, use PHP 8.1 with Debug ON and all (incl. deprecation) php warnings on, in fronted see warning with mod_search enabled.
Actual result BEFORE applying this Pull Request
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_search/mod_search.php on line 44Expected result AFTER applying this Pull Request
that warning disappears
Documentation Changes Required
none.