Skip to content

[5.3] php 8.4 compatibility#45169

Merged
laoneo merged 1 commit intojoomla:5.3-devfrom
brianteeman:mfartetry
Mar 21, 2025
Merged

[5.3] php 8.4 compatibility#45169
laoneo merged 1 commit intojoomla:5.3-devfrom
brianteeman:mfartetry

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Summary of Changes

PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

Testing Instructions

Code review or use the cypress integration tests for mfa with php 8.4
npx cypress run --spec '.\tests\System\integration\administrator\components\com_users\Mfa.cy.js'

Actual result BEFORE applying this Pull Request

php deprecated message in the logs

Expected result AFTER applying this Pull Request

no deprecated message in the logs

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

PHP Deprecated:  strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated

Signed-off-by: BrianTeeman <brian@teeman.net>
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 20, 2025

I have tested this item ✅ successfully on 714f3d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45169.

1 similar comment
@joomdonation
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 714f3d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45169.

@joomdonation
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45169.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 21, 2025
@laoneo laoneo merged commit bfad6f1 into joomla:5.3-dev Mar 21, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2025
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 21, 2025

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 21, 2025
@brianteeman brianteeman deleted the mfartetry branch March 21, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants