[4.0] Clean up inline js #1#18944
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Dec 2, 2017
dgrammatiko:no-inline-js/1
Merged
[4.0] Clean up inline js #1#18944wilsonge merged 4 commits intojoomla:4.0-devfrom dgrammatiko:no-inline-js/1
wilsonge merged 4 commits intojoomla:4.0-devfrom
dgrammatiko:no-inline-js/1
Conversation
C-Lodder
reviewed
Dec 1, 2017
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
| (function() { | ||
| if (!window.Joomla) { |
Member
There was a problem hiding this comment.
if (!Joomla) {
and this file should be minified ;)
Contributor
Author
There was a problem hiding this comment.
not by hand, once the new build script is merged!
C-Lodder
approved these changes
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
com_categories modal view. There is one instance of inline script in Field/CategoryField but this will be done in the PR that will refactor the modal field (not the greatest piece of code in the project)
Testing Instructions
Create a menu: Category blog -> try to select a category, if it works test is passing
Expected result
Actual result
Documentation Changes Required
The minified js is not minified, that will be done by Grunt so please no smartypants call to fix that! It's on purpose.