Skip to content

Remove katex example#11894

Merged
bryevdv merged 3 commits intobranch-3.0from
timo/11870_delete_katex_example
Dec 14, 2021
Merged

Remove katex example#11894
bryevdv merged 3 commits intobranch-3.0from
timo/11870_delete_katex_example

Conversation

@tcmetzger
Copy link
Copy Markdown
Member

As discussed in #11879, this PR removes the old examples using Katex. fixes #11870

@tcmetzger
Copy link
Copy Markdown
Member Author

@bryevdv @mattpap This PR removes both the Katex example and the unit test based on that example. There are two individual commits, in case we want to keep the unit test.

@tcmetzger tcmetzger requested a review from bryevdv December 14, 2021 00:43
@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 14, 2021

@tcmetzger I think the files under tests/unit/bokeh/embed can/should stay for now. I didn't realize the unit tests used a latex example, but it is not at all user-facing so I am less concerned about anyone stumbling across it. Otherwise, some important tests for extension features have to be deleted, and that is not good. But there should definitely be a new issue about replacing the user examples, and it should link to this PR so that the test example can also be updated at that time.

@tcmetzger
Copy link
Copy Markdown
Member Author

@bryevdv I reverted the commit removing the unit test, should be all good now! 😀

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 14, 2021

Thanks @tcmetzger

@bryevdv bryevdv merged commit c0aa52c into branch-3.0 Dec 14, 2021
@bryevdv bryevdv deleted the timo/11870_delete_katex_example branch December 14, 2021 04:04
bryevdv pushed a commit that referenced this pull request May 15, 2022
* Remove katex example

* Remove test based on katex example

* Revert "Remove test based on katex example"

This reverts commit f0df5ed.
@bryevdv bryevdv mentioned this pull request May 15, 2022
@bryevdv bryevdv modified the milestones: 3.0, 2.4.3 May 16, 2022
bryevdv added a commit that referenced this pull request May 16, 2022
* Update CONTRIBUTING.MD (#11957)

* track modified files in release build more carefully (#11972)

* Remove katex example (#11894)

* Remove katex example

* Remove test based on katex example

* Revert "Remove test based on katex example"

This reverts commit f0df5ed.

* Cleaner white space/indentation in templates (#11866)

* Enable block trimming, add initial test

* Add test for script start/stops

* Trim comment blocks in templates

* Remove hard-coded white space in templates

* Minimize manual trimming/indenting

* Clean up indentation, standardize CSS/JS

* Simplify new template test

* Expand new test to cover multiple resource modes

* Reduce whitespace around title and scripts

* isort, lint test_templates

* Combine JS/CSS resource defs in test_templates

* Reduce indent of plot script

* Consistent indentation in template itself

* Update template in docs

* 11726 Updated links to visjs.org Graph3d examples (#11728)

* Add sphinx_copybutton (#11993)

* Add sphinx_copybutton

* Update CI environments

* Move sphinx-copybutton to pip dependencies

* Fix typo in tools.py (#11935)

perfrom -> perform

* Fixed a few typos and changed wordings (#11698)

* Fix issue probably-meant-fstring found at https://codereview.doctor (#12097)

* add functools.wraps to _needs_document_lock_wrapper (#11976)

dask.distributed intermittently logs:
`RuntimeWarning: coroutine '_needs_document_lock.<locals>._needs_document_lock_wrapper' was never awaited`
with this wrapper it will be possible to see which method wasn't
awaited

* Md files checking and updating (#11903)

* Update readme

Resolving issue [#11868] (#11868)

* Update README.md

* Update README.md

* Update README.md

* Update commits with comments from #11903

* Update according to #1193 comments

* Update readme to comply code quality test

* update readme to comply code quality issues

* Elaborate on git commit/push process in docs (#11758)

* Add more git instructions

* Fix typo in models contributor guide

* Update sphinx/source/docs/dev_guide/pull_requests.rst

Co-authored-by: Timo Cornelius Metzger <39711796+tcmetzger@users.noreply.github.com>

Co-authored-by: Timo Cornelius Metzger <39711796+tcmetzger@users.noreply.github.com>

* Hover tooltips for Patch and Areas (#11992)

* Initial functioning WIP

* WIP Patch and HArea

* check for potentially null value

* Remove commented out code

* remove unnecessary to_screen call

* break after successful polygon hit test

* Add a comment regarding selection.is_empty()

Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>

* Remove references to gen.coroutine from docs and update without_document_lock decorator (#12010)

* Update without_document_lock to decorate async functions and asyncio.coroutines as well

* Update docs to use async functions instead of tornado.gen.coroutines

* Add fact that async funcs are accepted in docstring

* Add test for async func decorated by without_document_lock

* Remove trailing whitespace

* simplify CI jobs with composite action (#11833)

* simplfy CI jobs with composite action

* lower verbosity on unpack

* Removed unnecessary calls to _recompute_all_models() to speed up adding roots (#11739)

* Removed unnecessary calls to _recompute_all_models() to speed up adding roots

* Corrected last commit so that general calls to add_root() still call recompute_all_models(), and that is only worked around in special situations.

* Wrapping calls to add_root() within push_all_models_freeze()

* Made last commit more elegant by getting rid of loop

Co-authored-by: Efrem Braun <efrem.braun@gmail.comm>

Co-authored-by: Timo Cornelius Metzger <39711796+tcmetzger@users.noreply.github.com>
Co-authored-by: g-parki <61096711+g-parki@users.noreply.github.com>
Co-authored-by: Bill <35750915+roadswitcher@users.noreply.github.com>
Co-authored-by: Ikko Ashimine <eltociear@gmail.com>
Co-authored-by: Harold <eldrickmargarejo@gmail.com>
Co-authored-by: code-review-doctor <72647856+code-review-doctor@users.noreply.github.com>
Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: girolamo <58935223+girolamodaschio@users.noreply.github.com>
Co-authored-by: Alex Pilon <alex.pilon@gmail.com>
Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
Co-authored-by: Ben Russell <bprussell80@protonmail.com>
Co-authored-by: Efrem Braun <efrem.braun@gmail.com>
Co-authored-by: Efrem Braun <efrem.braun@gmail.comm>
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove katex example, test and docs

3 participants