Skip to content

More 2.4.3 backports#12130

Merged
bryevdv merged 16 commits intobranch-2.4from
bryanv/243_ports
May 16, 2022
Merged

More 2.4.3 backports#12130
bryevdv merged 16 commits intobranch-2.4from
bryanv/243_ports

Conversation

tcmetzger and others added 8 commits May 15, 2022 16:06
* Remove katex example

* Remove test based on katex example

* Revert "Remove test based on katex example"

This reverts commit f0df5ed.
* Enable block trimming, add initial test

* Add test for script start/stops

* Trim comment blocks in templates

* Remove hard-coded white space in templates

* Minimize manual trimming/indenting

* Clean up indentation, standardize CSS/JS

* Simplify new template test

* Expand new test to cover multiple resource modes

* Reduce whitespace around title and scripts

* isort, lint test_templates

* Combine JS/CSS resource defs in test_templates

* Reduce indent of plot script

* Consistent indentation in template itself

* Update template in docs
* Add sphinx_copybutton

* Update CI environments

* Move sphinx-copybutton to pip dependencies
@bryevdv bryevdv added this to the 2.4.3 milestone May 16, 2022
@bryevdv bryevdv changed the title Bryanv/243 ports More 2.4.3 backports May 16, 2022
code-review-doctor and others added 8 commits May 15, 2022 17:11
dask.distributed intermittently logs:
`RuntimeWarning: coroutine '_needs_document_lock.<locals>._needs_document_lock_wrapper' was never awaited`
with this wrapper it will be possible to see which method wasn't
awaited
* Update readme

Resolving issue [#11868] (#11868)

* Update README.md

* Update README.md

* Update README.md

* Update commits with comments from #11903

* Update according to #1193 comments

* Update readme to comply code quality test

* update readme to comply code quality issues
* Add more git instructions

* Fix typo in models contributor guide

* Update sphinx/source/docs/dev_guide/pull_requests.rst

Co-authored-by: Timo Cornelius Metzger <39711796+tcmetzger@users.noreply.github.com>

Co-authored-by: Timo Cornelius Metzger <39711796+tcmetzger@users.noreply.github.com>
* Initial functioning WIP

* WIP Patch and HArea

* check for potentially null value

* Remove commented out code

* remove unnecessary to_screen call

* break after successful polygon hit test

* Add a comment regarding selection.is_empty()

Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
…ent_lock decorator (#12010)

* Update without_document_lock to decorate async functions and asyncio.coroutines as well

* Update docs to use async functions instead of tornado.gen.coroutines

* Add fact that async funcs are accepted in docstring

* Add test for async func decorated by without_document_lock

* Remove trailing whitespace
* simplfy CI jobs with composite action

* lower verbosity on unpack
…ng roots (#11739)

* Removed unnecessary calls to _recompute_all_models() to speed up adding roots

* Corrected last commit so that general calls to add_root() still call recompute_all_models(), and that is only worked around in special situations.

* Wrapping calls to add_root() within push_all_models_freeze()

* Made last commit more elegant by getting rid of loop

Co-authored-by: Efrem Braun <efrem.braun@gmail.comm>
@bryevdv
Copy link
Copy Markdown
Member Author

bryevdv commented May 16, 2022

OK examples report and a quick look at local docs looks good. I am going to go ahead and merge this, then do a PR for the copyright dates updates, then make a dev2

@bryevdv bryevdv merged commit 1b29f0b into branch-2.4 May 16, 2022
@bryevdv bryevdv deleted the bryanv/243_ports branch May 16, 2022 02:24
@bryevdv
Copy link
Copy Markdown
Member Author

bryevdv commented May 16, 2022

In the interest of expediency I just pushed the cc date update pick directly to branch-2.4 in dd6f6da after verifying it was comments-only

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.