Skip to content

Add note on LaTeX support to wrapped extension examples (katex)#11879

Closed
tcmetzger wants to merge 1 commit intobranch-3.0from
timo/11870_wrapped_extension_examples
Closed

Add note on LaTeX support to wrapped extension examples (katex)#11879
tcmetzger wants to merge 1 commit intobranch-3.0from
timo/11870_wrapped_extension_examples

Conversation

@tcmetzger
Copy link
Copy Markdown
Member

@tcmetzger tcmetzger commented Dec 9, 2021

This PR adds notes to the wrapped extension examples using katex (wrapped_extension_full and wrapped_extension_base).

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 10, 2021

I'd really like to just remove everything katex-related entirely, I think their continued presence will be confusing. But then I guess we need some new examples to illustrate the different levels of extensions authoring. @mattpap do you have any suitable replacements on hand?

@tcmetzger
Copy link
Copy Markdown
Member Author

tcmetzger commented Dec 10, 2021

I agree the goal should definitely be to change the example to something that does not involve LaTeX at all.

How about in the meantime we merge this PR (and close the original issue), and I’ll create a follow up issue to change the two extension examples. This way we can keep the example in the branch, as a starting point for someone to update it.

Or just delete it, of course, I’d also be happy to update my PR to do that!

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 13, 2021

I'd personally rather just delete them now and make a new milestone-3.0 issue to replace them with something else later

@mattpap
Copy link
Copy Markdown
Contributor

mattpap commented Dec 13, 2021

I don't have any examples in mind right now, and given that the existing are barely helpful (e.g. abusing Label implementation), I would just remove the existing and come up with a new set later on.

@bryevdv
Copy link
Copy Markdown
Member

bryevdv commented Dec 13, 2021

@tcmetzger I think everyone is agreed on "just remove them entirely immediately"

@tcmetzger
Copy link
Copy Markdown
Member Author

Thanks, I'll update this PR soon!

@tcmetzger
Copy link
Copy Markdown
Member Author

Superseded by #11894

@tcmetzger tcmetzger closed this Dec 13, 2021
@tcmetzger tcmetzger deleted the timo/11870_wrapped_extension_examples branch December 13, 2021 23:25
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove katex example, test and docs

3 participants