guix: move bison from global scope, to Linux #30534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only needed for the Qt build, on Linux, so does not need to be built/present for the macOS or Windows builds.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use] |
sedited
reviewed
Jul 27, 2024
Contributor
sedited
left a comment
There was a problem hiding this comment.
Guix build (aarch64):
e06b7ed42cf35c58bce65af5802a50c16b8eb570c1f39b32538dffa9c37d57f8 guix-build-e6df3485ed23/output/aarch64-linux-gnu/SHA256SUMS.part
aaae74d5c922a550d377c0de76fd54799df88b6efc53482c641e09bdee77362b guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu-debug.tar.gz
050b5409cd77dd3636deb37f4f9524fc34ea1a957f86b96fc427a65d067097be guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu.tar.gz
41d31c52e482379da1a3ea587abc6dd06d2fabe9a9d0146b02e98e1953ed81ae guix-build-e6df3485ed23/output/arm-linux-gnueabihf/SHA256SUMS.part
a3c8f1c98674ae46bd858bf9c9738f27e0e3bf7f88c6b8fe4666ba053b8950c2 guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf-debug.tar.gz
db2a25d235584e6f2743452ae48c7041565d8f4b08404f07e66e713f76f169ef guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf.tar.gz
6588b240103223af496c76bf722481fdad4d088a4ce94963276440424422eaa1 guix-build-e6df3485ed23/output/arm64-apple-darwin/SHA256SUMS.part
530e18cb3c44f84f2595ff9ac1961b6f786b0946e715330111671ae46f54dca3 guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.tar.gz
93938f04beffa2df56d2b3f2fce64e1349decd41072caa211b6714bd303642c4 guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.zip
f2592968ef02cf0e500ddc5b2c9a8bae170522d20356fd5ff895b8bfb24f7c62 guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin.tar.gz
98618f026a7e211761a09fe8c97fc9e13d18726204e020f1cea4340ab4615f2b guix-build-e6df3485ed23/output/dist-archive/bitcoin-e6df3485ed23.tar.gz
283f7b254b2e489fd51501b93318ee1ec90f1b0a63ab3f5607b3ac0b567ab438 guix-build-e6df3485ed23/output/powerpc64-linux-gnu/SHA256SUMS.part
9d0621b42f195783eb56c0bc2f2a99f8e4bf34cdbcecfe2b86078c1ebfa1830b guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu-debug.tar.gz
7ef162d8353ba0a8856ffb2e3cecb783d973c408d213ea72de5c51d9dde7da28 guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu.tar.gz
a5a777a32d49be5e9f5f2ea68f52470bb5ff4ca8cf1bd7f863b5cac5180a7787 guix-build-e6df3485ed23/output/riscv64-linux-gnu/SHA256SUMS.part
461a32589cf96945447da8d66263c203439903802c245713de15d88d48eb0f0b guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu-debug.tar.gz
0045b425d04ea03158e300b7b5b47523589ac730861f3632d9e394261aaf69cf guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu.tar.gz
8c51307bfdb3ae66db70ce6dd21fdccc5ebcd7425482e8f68165670b81ccea97 guix-build-e6df3485ed23/output/x86_64-apple-darwin/SHA256SUMS.part
fd2c32ba1a8d87651e86f632fab9b8eba72cd43c8faf7ec20eb766d5d05cb432 guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.tar.gz
35b7caa4c62cd72eb12d13807380fba9dcfdf62f30a28e848c886986900f032d guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.zip
41ca0b7476e9a91f08d60c36ad3dbeb0538a42c3eca40e15e0d286c64c6faaab guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin.tar.gz
6b5d315e6985c466b0153c36baf9500767a4b4e6b55ec1e9380e79b1c288837f guix-build-e6df3485ed23/output/x86_64-linux-gnu/SHA256SUMS.part
87aefa71731cf735fba8ee21b172139d65953c138fbc75f5f1dd238d53c1d32d guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu-debug.tar.gz
3a6ccde6608fa8b19642b9b7623146c9b37871da16ae2d8801e31ebbf8251340 guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu.tar.gz
2bca8dd25e7b15869c889d1dfa3514d7dfd2cb89f35bf918a03bc01651df73e1 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/SHA256SUMS.part
067591caa19d972061fe4a0565f4bcae304afa02f70b23bc0dff65249be3f985 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-debug.zip
678ace84ce348af8b48ec39448faafbe259b8464d62b6a2eaf07c2b3ad065655 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-setup-unsigned.exe
fa8d04c1e48af8ba4dbaf4ab5d274c09f57f713312917712737255f19622ccdf guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-unsigned.tar.gz
f745e3dcfa3ce7f00bb4e5181c06518349511ff4e2985f543e98eff341b4e036 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64.zip
hebasto
approved these changes
Jul 28, 2024
Member
hebasto
left a comment
There was a problem hiding this comment.
My Guix build:
x86_64
e06b7ed42cf35c58bce65af5802a50c16b8eb570c1f39b32538dffa9c37d57f8 guix-build-e6df3485ed23/output/aarch64-linux-gnu/SHA256SUMS.part
aaae74d5c922a550d377c0de76fd54799df88b6efc53482c641e09bdee77362b guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu-debug.tar.gz
050b5409cd77dd3636deb37f4f9524fc34ea1a957f86b96fc427a65d067097be guix-build-e6df3485ed23/output/aarch64-linux-gnu/bitcoin-e6df3485ed23-aarch64-linux-gnu.tar.gz
41d31c52e482379da1a3ea587abc6dd06d2fabe9a9d0146b02e98e1953ed81ae guix-build-e6df3485ed23/output/arm-linux-gnueabihf/SHA256SUMS.part
a3c8f1c98674ae46bd858bf9c9738f27e0e3bf7f88c6b8fe4666ba053b8950c2 guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf-debug.tar.gz
db2a25d235584e6f2743452ae48c7041565d8f4b08404f07e66e713f76f169ef guix-build-e6df3485ed23/output/arm-linux-gnueabihf/bitcoin-e6df3485ed23-arm-linux-gnueabihf.tar.gz
6588b240103223af496c76bf722481fdad4d088a4ce94963276440424422eaa1 guix-build-e6df3485ed23/output/arm64-apple-darwin/SHA256SUMS.part
530e18cb3c44f84f2595ff9ac1961b6f786b0946e715330111671ae46f54dca3 guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.tar.gz
93938f04beffa2df56d2b3f2fce64e1349decd41072caa211b6714bd303642c4 guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin-unsigned.zip
f2592968ef02cf0e500ddc5b2c9a8bae170522d20356fd5ff895b8bfb24f7c62 guix-build-e6df3485ed23/output/arm64-apple-darwin/bitcoin-e6df3485ed23-arm64-apple-darwin.tar.gz
98618f026a7e211761a09fe8c97fc9e13d18726204e020f1cea4340ab4615f2b guix-build-e6df3485ed23/output/dist-archive/bitcoin-e6df3485ed23.tar.gz
283f7b254b2e489fd51501b93318ee1ec90f1b0a63ab3f5607b3ac0b567ab438 guix-build-e6df3485ed23/output/powerpc64-linux-gnu/SHA256SUMS.part
9d0621b42f195783eb56c0bc2f2a99f8e4bf34cdbcecfe2b86078c1ebfa1830b guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu-debug.tar.gz
7ef162d8353ba0a8856ffb2e3cecb783d973c408d213ea72de5c51d9dde7da28 guix-build-e6df3485ed23/output/powerpc64-linux-gnu/bitcoin-e6df3485ed23-powerpc64-linux-gnu.tar.gz
a5a777a32d49be5e9f5f2ea68f52470bb5ff4ca8cf1bd7f863b5cac5180a7787 guix-build-e6df3485ed23/output/riscv64-linux-gnu/SHA256SUMS.part
461a32589cf96945447da8d66263c203439903802c245713de15d88d48eb0f0b guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu-debug.tar.gz
0045b425d04ea03158e300b7b5b47523589ac730861f3632d9e394261aaf69cf guix-build-e6df3485ed23/output/riscv64-linux-gnu/bitcoin-e6df3485ed23-riscv64-linux-gnu.tar.gz
8c51307bfdb3ae66db70ce6dd21fdccc5ebcd7425482e8f68165670b81ccea97 guix-build-e6df3485ed23/output/x86_64-apple-darwin/SHA256SUMS.part
fd2c32ba1a8d87651e86f632fab9b8eba72cd43c8faf7ec20eb766d5d05cb432 guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.tar.gz
35b7caa4c62cd72eb12d13807380fba9dcfdf62f30a28e848c886986900f032d guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin-unsigned.zip
41ca0b7476e9a91f08d60c36ad3dbeb0538a42c3eca40e15e0d286c64c6faaab guix-build-e6df3485ed23/output/x86_64-apple-darwin/bitcoin-e6df3485ed23-x86_64-apple-darwin.tar.gz
6b5d315e6985c466b0153c36baf9500767a4b4e6b55ec1e9380e79b1c288837f guix-build-e6df3485ed23/output/x86_64-linux-gnu/SHA256SUMS.part
87aefa71731cf735fba8ee21b172139d65953c138fbc75f5f1dd238d53c1d32d guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu-debug.tar.gz
3a6ccde6608fa8b19642b9b7623146c9b37871da16ae2d8801e31ebbf8251340 guix-build-e6df3485ed23/output/x86_64-linux-gnu/bitcoin-e6df3485ed23-x86_64-linux-gnu.tar.gz
2bca8dd25e7b15869c889d1dfa3514d7dfd2cb89f35bf918a03bc01651df73e1 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/SHA256SUMS.part
067591caa19d972061fe4a0565f4bcae304afa02f70b23bc0dff65249be3f985 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-debug.zip
678ace84ce348af8b48ec39448faafbe259b8464d62b6a2eaf07c2b3ad065655 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-setup-unsigned.exe
fa8d04c1e48af8ba4dbaf4ab5d274c09f57f713312917712737255f19622ccdf guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64-unsigned.tar.gz
f745e3dcfa3ce7f00bb4e5181c06518349511ff4e2985f543e98eff341b4e036 guix-build-e6df3485ed23/output/x86_64-w64-mingw32/bitcoin-e6df3485ed23-win64.zip
hebasto
approved these changes
Jul 28, 2024
sedited
approved these changes
Jul 28, 2024
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Aug 1, 2024
This is only needed for the Qt build, on Linux, so does not need to be built/present for the macOS or Windows builds. Github-Pull: bitcoin#30534 Rebased-From: e6df348
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 20, 2025
e6df348 guix: move bison from global scope, to Linux (fanquake) Pull request description: This is only needed for the Qt build (libxkbcommon), on Linux, so does not need to be built/present for the macOS or Windows builds. ACKs for top commit: hebasto: ACK e6df348. TheCharlatan: ACK e6df348 Tree-SHA512: b66111e398b4fce88f912adfd808d537e2d85e1f0078befd264bb700b201ca1bbe322810e80a212e0023657e9e3693a106761c43743d66aabd16e2afe7f599e6
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Feb 21, 2025
c34e7ab Merge bitcoin#30534: guix: move bison from global scope, to Linux (merge-script) da11d29 Merge bitcoin#30282: Revert "contrib: macdeploy: monkey-patch gen-sdk to be deterministic" (merge-script) 20bcee8 Merge bitcoin#30281: Update leveldb subtree to latest upstream (merge-script) a74b1e2 Merge bitcoin#30253: refactor: performance-for-range-copy in psbt.h (merge-script) 2ea479f Merge bitcoin#29650: depends: drop 1 Qt determinism patch (fanquake) 6506f52 Merge bitcoin#28833: wallet: refactor: remove unused `SignatureData` instances in spkm's `FillPSBT` methods (Ava Chow) 6235590 Merge bitcoin#29213: doc, test: test and explain service flag handling (Ava Chow) 34bbe69 Merge bitcoin#28965: guix: remove input labels (fanquake) 490b390 Merge bitcoin#28859: guix: update signapple (drop macho & altgraph) (fanquake) a12ad80 Merge bitcoin#28325: test: wallet_backup.py, fix intermittent failure in "restore using dumped wallet" (fanquake) 15f8b74 Merge bitcoin#27779: guix: remove cURL from build env (fanquake) 1289d32 Merge bitcoin#27801: wallet: Add tracing for sqlite statements (fanquake) ba3aff7 Merge bitcoin-core/gui#729: test: Add missed header (Hennadii Stepanov) 536a265 Merge bitcoin#27209: ci: Remove unused EXPECTED_TESTS_DURATION_IN_SECONDS env var (glozow) f2caccd Merge bitcoin#27174: ci: bump lint task to bookworm for git v2.38 (fanquake) 0be2932 Merge bitcoin#27009: validation: Skip VerifyDB checks of level >=3 if dbcache is too small (fanquake) Pull request description: ## Issue being fixed or feature implemented Batch of trivial back ports ## What was done? ## How Has This Been Tested? Built locally; haven't reviewed commits yet. ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK c34e7ab kwvg: utACK c34e7ab Tree-SHA512: e20270e48273ad5fd5926e75b025fe69a70e698a82f0a11a1fa646c44a7affbd7a5f33eebcd7faa606e7adc2a888df141c660339d7240e6ed64f8525558215de
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only needed for the Qt build (libxkbcommon), on Linux, so does not need to be built/present for the macOS or Windows builds.